From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6BD8FA3728 for ; Wed, 16 Oct 2019 22:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93170207FF for ; Wed, 16 Oct 2019 22:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263664; bh=+WE4tjlXZqjqm0OKQhSdWH0UsVZN/AZldVrWR4B5oPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=im+aCzbjmA6u0UjbZvOYUMPl+SQo8V6CK4FD+FcuHDIq4AqwftiVxraWTaH2zdKiR LKLVVsAWVJIfRHdnv95fO+H2mZwn47wmVCERDdKPukJEKuPvs6oPqc8hrkNshXDlB8 sHIqRHHhxthNZPztVAPSOA/dzHSG+Mp3oBqd6RVg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439065AbfJPWHn (ORCPT ); Wed, 16 Oct 2019 18:07:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:51328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395556AbfJPV6F (ORCPT ); Wed, 16 Oct 2019 17:58:05 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A7E5222C4; Wed, 16 Oct 2019 21:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263085; bh=+WE4tjlXZqjqm0OKQhSdWH0UsVZN/AZldVrWR4B5oPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R7SKoAxX519z0tRipaaLAZOAAAOHa5hbPepqOCFGvLu+/PtettsSZhDSxBaQCOdrg SKjd6WZ1/jkmTpOT5DaGhvXjsRMpVshXeWLNf2D9sUf8DtDb7XGPlA2Yct3TGqtXCf xSRLXCo18S4l6AOTlO3Jh8UcPFRvlcjQ1GMgD11k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Dan Carpenter Subject: [PATCH 4.19 43/81] Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc Date: Wed, 16 Oct 2019 14:50:54 -0700 Message-Id: <20191016214838.706114947@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214805.727399379@linuxfoundation.org> References: <20191016214805.727399379@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit 5bdea6060618cfcf1459dca137e89aee038ac8b9 upstream. In fbtft_framebuffer_alloc the error handling path should take care of releasing frame buffer after it is allocated via framebuffer_alloc, too. Therefore, in two failure cases the goto destination is changed to address this issue. Fixes: c296d5f9957c ("staging: fbtft: core support") Signed-off-by: Navid Emamdoost Reviewed-by: Dan Carpenter Cc: stable Link: https://lore.kernel.org/r/20190930030949.28615-1-navid.emamdoost@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/fbtft/fbtft-core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -819,7 +819,7 @@ struct fb_info *fbtft_framebuffer_alloc( if (par->gamma.curves && gamma) { if (fbtft_gamma_parse_str(par, par->gamma.curves, gamma, strlen(gamma))) - goto alloc_fail; + goto release_framebuf; } /* Transmit buffer */ @@ -836,7 +836,7 @@ struct fb_info *fbtft_framebuffer_alloc( if (txbuflen > 0) { txbuf = devm_kzalloc(par->info->device, txbuflen, GFP_KERNEL); if (!txbuf) - goto alloc_fail; + goto release_framebuf; par->txbuf.buf = txbuf; par->txbuf.len = txbuflen; } @@ -872,6 +872,9 @@ struct fb_info *fbtft_framebuffer_alloc( return info; +release_framebuf: + framebuffer_release(info); + alloc_fail: vfree(vmem);