From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A3AFA3728 for ; Wed, 16 Oct 2019 22:05:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9045D21928 for ; Wed, 16 Oct 2019 22:05:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263553; bh=HIAuGaaioLIQFgy5x+2q4gdqBHXPwkNmZcHznQAe/0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=g4Mp2Xy47qtdKShRI2UDedoO5CCNPiEPl87tp4u80zqZDJsw/HPVgHWgNj3ucSKZ2 xS7dYN5HnbSA+2kcv2/EKBrPymgT+sqjoNjWN0232QsCPpDbX1BqnhKtmfRPYtnVbe kLHqS3hMAQq5pwYdXv0kpUBcJO/NSAkP3aLeGZzo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406976AbfJPWFv (ORCPT ); Wed, 16 Oct 2019 18:05:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:52546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438239AbfJPV6n (ORCPT ); Wed, 16 Oct 2019 17:58:43 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D95521928; Wed, 16 Oct 2019 21:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263122; bh=HIAuGaaioLIQFgy5x+2q4gdqBHXPwkNmZcHznQAe/0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TEvyWr0eUx7jxh9GpqzRnsDni/pYf4LE8kmtKTSK/IUxuJe6tl7q1IbHZ9jq/3gYk lLpomtRZAjg7io1/Qh2gZJ1X/2kGnweK2wXNM5kZzFGk8+wyatsLK0E3j+0gh1p53j E5MREIqOqQiyaMf2gXtkyFtyLcjn4rZ5It+AMU1g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bruce Chen , Baolin Wang , Bartosz Golaszewski Subject: [PATCH 5.3 046/112] gpio: eic: sprd: Fix the incorrect EIC offset when toggling Date: Wed, 16 Oct 2019 14:50:38 -0700 Message-Id: <20191016214855.052818171@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214844.038848564@linuxfoundation.org> References: <20191016214844.038848564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bruce Chen commit e91aafcb51f3c5001ae76c3ee027beb0b8506447 upstream. When toggling the level trigger to emulate the edge trigger, the EIC offset is incorrect without adding the corresponding bank index, thus fix it. Fixes: 7bf0d7f62282 ("gpio: eic: Add edge trigger emulation for EIC") Cc: stable@vger.kernel.org Signed-off-by: Bruce Chen Signed-off-by: Baolin Wang Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-eic-sprd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -530,11 +530,12 @@ static void sprd_eic_handle_one_type(str } for_each_set_bit(n, ®, SPRD_EIC_PER_BANK_NR) { - girq = irq_find_mapping(chip->irq.domain, - bank * SPRD_EIC_PER_BANK_NR + n); + u32 offset = bank * SPRD_EIC_PER_BANK_NR + n; + + girq = irq_find_mapping(chip->irq.domain, offset); generic_handle_irq(girq); - sprd_eic_toggle_trigger(chip, girq, n); + sprd_eic_toggle_trigger(chip, girq, offset); } } }