From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] cpufreq: merge arm_big_little and vexpress-spc
Date: Thu, 17 Oct 2019 10:26:28 +0100 [thread overview]
Message-ID: <20191017092628.GD8978@bogus> (raw)
In-Reply-To: <20191017023936.vgkdfnyaz3r4k74z@vireshk-i7>
On Thu, Oct 17, 2019 at 08:09:36AM +0530, Viresh Kumar wrote:
> On 16-10-19, 12:03, Sudeep Holla wrote:
> > arm_big_little cpufreq driver was designed as a generic big little
> > driver that could be used by any platform and make use of bL switcher.
> > Over years alternate solutions have be designed and merged to deal with
> > bL/HMP systems like EAS.
> >
> > Also since no other driver made use of generic arm_big_little cpufreq
> > driver except Vexpress SPC, we can merge them together as vexpress-spc
> > driver used only on Vexpress TC2(CA15_CA7) platform.
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > MAINTAINERS | 5 +-
> > drivers/cpufreq/Kconfig.arm | 12 +-
> > drivers/cpufreq/Makefile | 2 -
> > drivers/cpufreq/arm_big_little.c | 658 ------------------------
> > drivers/cpufreq/arm_big_little.h | 43 --
> > drivers/cpufreq/vexpress-spc-cpufreq.c | 661 ++++++++++++++++++++++++-
> > 6 files changed, 652 insertions(+), 729 deletions(-)
> > delete mode 100644 drivers/cpufreq/arm_big_little.c
> > delete mode 100644 drivers/cpufreq/arm_big_little.h
>
> The delta produced here is enormous probably because you copy/pasted things. I
> am wondering if using git mv to rename arm_big_little.c and then move spc bits
> into it will make this delta smaller to review ?
>
Yes, I did a quick try but slightly different order. As I need the final
driver to be vexpress-spc-cpufreq.c, I am thinking of first merging
vexpress-spc-cpufreq.c into arm_big_little.c and then renaming it back
later. Does that sound good ?
drivers/cpufreq/arm_big_little.c | 78 ++++++++++++++++++++------
drivers/cpufreq/arm_big_little.h | 43 --------------
drivers/cpufreq/vexpress-spc-cpufreq.c | 71 -----------------------
6 files changed, 68 insertions(+), 145 deletions(-)
delete mode 100644 drivers/cpufreq/arm_big_little.h
delete mode 100644 drivers/cpufreq/vexpress-spc-cpufreq.c
If we first rename arm_big_little.c, then we need change the final name
otherwise we end up with same delta as the new name file will be merged
into vexpress-spc-cpufreq.c
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-10-17 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:03 [PATCH 0/3] cpufreq: merge arm_big_little and vexpress-spc Sudeep Holla
2019-10-16 11:03 ` [PATCH 1/3] cpufreq: scpi: remove stale/outdated comment about the driver Sudeep Holla
2019-10-16 11:03 ` [PATCH 2/3] cpufreq: merge arm_big_little and vexpress-spc Sudeep Holla
2019-10-17 2:39 ` Viresh Kumar
2019-10-17 9:26 ` Sudeep Holla [this message]
2019-10-17 9:30 ` Viresh Kumar
2019-10-17 9:58 ` Sudeep Holla
2019-10-16 11:03 ` [PATCH 3/3] cpufreq: simplify and remove lots of debug messages Sudeep Holla
2019-10-17 2:42 ` Viresh Kumar
2019-10-17 9:14 ` Sudeep Holla
2019-10-17 2:43 ` [PATCH 0/3] cpufreq: merge arm_big_little and vexpress-spc Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017092628.GD8978@bogus \
--to=sudeep.holla@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox