From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, kan.liang@intel.com,
yao.jin@intel.com
Subject: Re: [PATCH v2] perf list: Separate the deprecated events
Date: Thu, 17 Oct 2019 17:21:00 +0200 [thread overview]
Message-ID: <20191017152100.GC21168@krava> (raw)
In-Reply-To: <20191017144644.GV9933@tassilo.jf.intel.com>
On Thu, Oct 17, 2019 at 07:46:44AM -0700, Andi Kleen wrote:
> > v2:
> > ---
> > In v1, the deprecated events are hidden by default but they can be
> > displayed when option "--deprecated" is enabled. In v2, we don't use
> > the new option "--deprecated". Instead, we just display the deprecated
> > events under the title "--- Following are deprecated events ---".
>
> It's redundant with what the event description already says.
> If we always want to show it we don't need to do anything.
>
> I really would much prefer to hide it. What's the point of showing
> something that people are not supposed to use?
>
> The only reason for keeping the deprecated events is to not
> break old scripts, but those don't care about perf list output.
I thought this might be a problem for users,
but don't have anything to back this up ;-)
if that's the case we can go with the original patch
jirka
>
> So I think the only sane option is to hide it by default.
>
> -Andi
next prev parent reply other threads:[~2019-10-17 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 13:52 [PATCH v2] perf list: Separate the deprecated events Jin Yao
2019-10-17 14:46 ` Andi Kleen
2019-10-17 15:21 ` Jiri Olsa [this message]
2019-10-18 0:13 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017152100.GC21168@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox