Re: [PATCH v5 11/14] software node: move small properties inline when copying

Andy Shevchenko
2019-10-15T12:20:34Z

On Fri, Oct 11, 2019 at 04:07:18PM -0700, Dmitry Torokhov wrote:
> When copying/duplicating set of properties, move smaller properties that
> were stored separately directly inside property entry structures. We can
> move:
>
> - up to 8 bytes from U8 arrays
> - up to 4 words
> - up to 2 double words
> - one U64 value
> - one or 2 strings.

Can you show where you extract such values?

> + if (!dst->is_inline && dst->length <= sizeof(dst->value)) {
> + /* We have an opportunity to move the data inline */
> + const void *tmp = dst->pointer;
> +

> + memcpy(&dst->value, tmp, dst->length);

...because this is strange trick.

> + dst->is_inline = true;
> +
> + kfree(tmp);
> + }

--
With Best Regards,
Andy Shevchenko