Re: [Patch 5/9] arm: dts: dra72-evm-common: Add entries for the CSI2 cameras

Tony Lindgren
2019-10-22T16:27:47Z

* Benoit Parrot <bparrot@ti.com> [191022 16:17]:
> Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 08:44:46 -0700]:
> > * Benoit Parrot <bparrot@ti.com> [191018 15:46]:
> > > Add device nodes for CSI2 camera board OV5640.
> > > Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
> > >
> > > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > > ---
> > > arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +++++++++++++++++++++++++
> > > 1 file changed, 35 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > index 8641a3d7d8ad..e4c01a67f6de 100644
> > > --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > @@ -187,6 +187,12 @@
> > > gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>;
> > > enable-active-high;
> > > };
> > > +
> > > + clk_ov5640_fixed: clk_ov5640_fixed {
> > > + compatible = "fixed-clock";
> > > + #clock-cells = <0>;
> > > + clock-frequency = <24000000>;
> > > + };
> > > };
> >
> > The clock node name should be generic and not use
> > undescores. If there is a hidden dependency to the
> > clock node name here, it should be mentioned in the
> > patch for the non-standard use.
>
> Not sure what you mean by generic, here.
> This is just to provide a "clock" node which gives the "value" of the fixed
> oscillator frequency so driver can get to it, the actual name does not
> matter.

Oh just something like:

clk_ov5640_fixed: clock@foo {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <24000000>;
};

Or just clock if the only instance and no reg?

We currently get tons of warnings for TI clocks, that's
thousands of lines because of non-standard naming and
use of undescore instead of dash for the naming.. Let's
not add more.

Regards,

Tony