From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9462CA9EAF for ; Mon, 21 Oct 2019 13:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B4A72184C for ; Mon, 21 Oct 2019 13:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571665220; bh=9UxFmKuBFjeNvT1nzWgHQrO/jr2YDfCt399FobUHFrs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tmQSNQdICYNevCo3LA75D8uuhdYYXMLTSEwP947z+KJUx5yiDsmPCAbUe9W1JTqH+ Cda6wgPNbwv0zacoukTgs/+0SbTJzxqs70eIZZcGoVhG3LFDxM6ah/8Z/Ag2bgIVj4 0f29r/0Swqu91t59BjUZP0o2ylyVM0xQnPQhOGxs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729460AbfJUNkT (ORCPT ); Mon, 21 Oct 2019 09:40:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:42030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729441AbfJUNkR (ORCPT ); Mon, 21 Oct 2019 09:40:17 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E90AA214B2; Mon, 21 Oct 2019 13:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571665216; bh=9UxFmKuBFjeNvT1nzWgHQrO/jr2YDfCt399FobUHFrs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ly1AgBf15ZhXjnv18TsCyAXCb5gjRPEj3fhCyCvH6vTBbdx24jHzjbS+P5k08v4D8 B/4UHxsTPWyWRU/wSNWLpt8RfLRv60DQKBaBXz4TNxmifMFsDARA8YiTm9Ed6ZlsJr f40Tnh4GgY03JlTsqGEA1uLdiIq6FBI1uNDH0WVs= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , =?UTF-8?q?Luis=20Cl=C3=A1udio=20Gon=C3=A7alves?= Subject: [PATCH 29/57] perf trace: Show error message when not finding a field used in a filter expression Date: Mon, 21 Oct 2019 10:38:06 -0300 Message-Id: <20191021133834.25998-30-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191021133834.25998-1-acme@kernel.org> References: <20191021133834.25998-1-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo It was there, but as pr_debug(), make it pr_err() so that we can see it without -v: # trace -e syscalls:*lseek --filter="whenc==SET" sleep 1 "whenc" not found in "syscalls:sys_enter_lseek", can't set filter "whenc==SET" # Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Luis Cláudio Gonçalves Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-ly4rgm1bto8uwc2itpaixjob@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index e71605c99080..cafd18466dfa 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -3611,8 +3611,8 @@ static int trace__expand_filter(struct trace *trace __maybe_unused, struct evsel fmt = perf_evsel__syscall_arg_fmt(evsel, arg); if (fmt == NULL) { - pr_debug("\"%s\" not found in \"%s\", can't set filter \"%s\"\n", - arg, evsel->name, evsel->filter); + pr_err("\"%s\" not found in \"%s\", can't set filter \"%s\"\n", + arg, evsel->name, evsel->filter); return -1; } -- 2.21.0