From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Austin Bolen <austin_bolen@dell.com>,
keith.busch@intel.com, Alexandru Gagniuc <mr.nuke.me@gmail.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Sinan Kaya <okaya@kernel.org>,
Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
lukas@wunner.de
Subject: Re: [PATCH v3 3/3] PCI: pciehp: Add dmi table for in-band presence disabled
Date: Mon, 21 Oct 2019 16:47:29 +0300 [thread overview]
Message-ID: <20191021134729.GL2819@lahna.fi.intel.com> (raw)
In-Reply-To: <20191017193256.3636-4-stuart.w.hayes@gmail.com>
On Thu, Oct 17, 2019 at 03:32:56PM -0400, Stuart Hayes wrote:
> Some systems have in-band presence detection disabled for hot-plug PCI
> slots, but do not report this in the slot capabilities 2 (SLTCAP2) register.
> On these systems, presence detect can become active well after the link is
> reported to be active, which can cause the slots to be disabled after a
> device is connected.
>
> Add a dmi table to flag these systems as having in-band presence disabled.
>
> Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
> ---
> drivers/pci/hotplug/pciehp_hpc.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
> index 02eb811a014f..4d377a2a62ce 100644
> --- a/drivers/pci/hotplug/pciehp_hpc.c
> +++ b/drivers/pci/hotplug/pciehp_hpc.c
> @@ -14,6 +14,7 @@
>
> #define dev_fmt(fmt) "pciehp: " fmt
>
> +#include <linux/dmi.h>
> #include <linux/kernel.h>
> #include <linux/types.h>
> #include <linux/jiffies.h>
> @@ -26,6 +27,16 @@
> #include "../pci.h"
> #include "pciehp.h"
>
> +static const struct dmi_system_id inband_presence_disabled_dmi_table[] = {
> + {
> + .ident = "Dell System",
> + .matches = {
> + DMI_MATCH(DMI_OEM_STRING, "Dell System"),
Sorry if this has been discussed previously already but isn't this going
to apply on all Dell systems, not just the affected ones? Is this the
intention?
next prev parent reply other threads:[~2019-10-21 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 19:32 [PATCH v3 0/3] PCI: pciehp: Do not turn off slot if presence comes up after link Stuart Hayes
2019-10-17 19:32 ` [PATCH v3 1/3] PCI: pciehp: Add support for disabling in-band presence Stuart Hayes
2019-10-21 13:38 ` Mika Westerberg
2019-10-17 19:32 ` [PATCH v3 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled Stuart Hayes
2019-10-21 13:41 ` Mika Westerberg
2019-10-21 18:08 ` Stuart Hayes
2019-10-17 19:32 ` [PATCH v3 3/3] PCI: pciehp: Add dmi table for in-band presence disabled Stuart Hayes
2019-10-21 13:47 ` Mika Westerberg [this message]
2019-10-21 18:19 ` Stuart Hayes
2019-10-22 0:13 ` Alex G.
2019-10-22 9:42 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021134729.GL2819@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=gustavo@embeddedor.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox