From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C26CA9EB7 for ; Mon, 21 Oct 2019 13:50:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95405214B2 for ; Mon, 21 Oct 2019 13:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tycho-ws.20150623.gappssmtp.com header.i=@tycho-ws.20150623.gappssmtp.com header.b="MVs134l6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728970AbfJUNuS (ORCPT ); Mon, 21 Oct 2019 09:50:18 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:38899 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727322AbfJUNuR (ORCPT ); Mon, 21 Oct 2019 09:50:17 -0400 Received: by mail-il1-f195.google.com with SMTP id y5so12041420ilb.5 for ; Mon, 21 Oct 2019 06:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho-ws.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zDje2pQipVT5uUcMV42nQggbrwWDyHfBKgdKQtpAJaM=; b=MVs134l65t5BTYPgjlww6BVOq5twBjNypJjDDdRiPR03tSZB5KmazmM7KWo0unpIqY DGfnpuKRhxj29fSyYoXVwvctoq9Q1DSH8lungvp2tYJXOGkAlu53ZxxTandAuRwP+ohM ldRIoOrXCcESfHKgPTgWeya0dnmCyqEJL6uTuZMojIF8tVqFffYDkMCYtq7us0wz0RS9 sPL0JRtHvy4dyXwlwTyA/IiPbPOXeyVcn4hpwZnLUQXcSQ1AIoGVaNlOZ0c768aZGOYL r1usNZPqRHGTVY+LqkB+7U0eM4c9LTFw6HkCBzV/Cco8uqcFQ4WSbf2ldOIXD5hmaV8g mFdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zDje2pQipVT5uUcMV42nQggbrwWDyHfBKgdKQtpAJaM=; b=fyNxRD3xDiW3aZ3fxyGuu4RKWSVDNGeMAH5kI3BkK/Bu3Xlti4fIsaSp9E9Ghy+ltt hk1pjbn/HDL2aNe83VDHSWPaoUilbjuqFymtjjZ4DiyAgpITCJVvLJfqxIseUPtCQMeW iW7mX6Im0q9PsXXABABTaV8OuSRHDeHWG9oxFJkwvOVk8IzUa+BdsqvIHftvUneR4+Vk 4VjW4rTCHiNjxDVkFdu0eAoUwD+NDnxe2QpRyXuSsazYYkhCET6ClEZUecnYRZKheanT EQ4X767Zz7SywGOZFJ8PlHKx2JaoogcBtLFF1zOHvPwwFPeFfcg9CgKW/NAegY1aEbxE 7WAA== X-Gm-Message-State: APjAAAUCgwOgFLoNkRYVKNvR62Etjrdkx9tudAk2Wk+aOJv7dUMyNZbd BxhATAHQTM7dyOtDpmpYheedgA== X-Google-Smtp-Source: APXvYqyDQRodzUn85zMwBicd+7pAm0+7swizBLdALYp5OmQGKnooPyG4JtAFft9FRL/070YUpXxrJg== X-Received: by 2002:a05:6e02:68f:: with SMTP id o15mr25394236ils.210.1571665816762; Mon, 21 Oct 2019 06:50:16 -0700 (PDT) Received: from cisco ([2601:282:902:b340:c86c:807:8b9d:1010]) by smtp.gmail.com with ESMTPSA id v19sm4508156iol.24.2019.10.21.06.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 06:50:15 -0700 (PDT) Date: Mon, 21 Oct 2019 07:50:13 -0600 From: Tycho Andersen To: Christian Brauner Cc: linux-kernel@vger.kernel.org, keescook@chromium.org, rong.a.chen@intel.com, ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, lkp@lists.01.org, luto@amacapital.net, shuah@kernel.org, songliubraving@fb.com, tyhicks@canonical.com, wad@chromium.org, yhs@fb.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test Message-ID: <20191021135013.GD28452@cisco> References: <20191021084157.GG9296@shao2-debian> <20191021091055.4644-1-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191021091055.4644-1-christian.brauner@ubuntu.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 21, 2019 at 11:10:55AM +0200, Christian Brauner wrote: > The ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE was placed under the > ifndef for the SECCOMP_FILTER_FLAG_NEW_LISTENER feature. This will not > work on systems that do support SECCOMP_FILTER_FLAG_NEW_LISTENER but do not > support SECCOMP_USER_NOTIF_FLAG_CONTINUE. So move the latter ifndef out of > the former ifndef's scope. > > 2019-10-20 11:14:01 make run_tests -C seccomp > make: Entering directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' > gcc -Wl,-no-as-needed -Wall seccomp_bpf.c -lpthread -o seccomp_bpf > seccomp_bpf.c: In function ‘user_notification_continue’: > seccomp_bpf.c:3562:15: error: ‘SECCOMP_USER_NOTIF_FLAG_CONTINUE’ undeclared (first use in this function) > resp.flags = SECCOMP_USER_NOTIF_FLAG_CONTINUE; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > seccomp_bpf.c:3562:15: note: each undeclared identifier is reported only once for each function it appears in > Makefile:12: recipe for target 'seccomp_bpf' failed > make: *** [seccomp_bpf] Error 1 > make: Leaving directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' > > Reported-by: kernel test robot > Fixes: 0eebfed2954f ("seccomp: test SECCOMP_USER_NOTIF_FLAG_CONTINUE") > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Christian Brauner Reviewed-by: Tycho Andersen