From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 1/5] perf util: Create new block.h/block.c for block related functions
Date: Mon, 21 Oct 2019 18:08:11 +0200 [thread overview]
Message-ID: <20191021160811.GI32718@krava> (raw)
In-Reply-To: <20191015053350.13909-2-yao.jin@linux.intel.com>
On Tue, Oct 15, 2019 at 01:33:46PM +0800, Jin Yao wrote:
SNIP
> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index 39814b1806a6..3121c0055950 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -1,4 +1,5 @@
> perf-y += annotate.o
> +perf-y += block.o
> perf-y += block-range.o
> perf-y += build-id.o
> perf-y += cacheline.o
> diff --git a/tools/perf/util/block.c b/tools/perf/util/block.c
> new file mode 100644
> index 000000000000..e5e6f941f040
> --- /dev/null
> +++ b/tools/perf/util/block.c
please use block_info.c, block.c is misleading wrt what
we are doing here..
jirka
next prev parent reply other threads:[~2019-10-21 16:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 5:33 [PATCH v2 0/5] perf report: Support sorting all blocks by cycles Jin Yao
2019-10-15 5:33 ` [PATCH v2 1/5] perf util: Create new block.h/block.c for block related functions Jin Yao
2019-10-21 16:08 ` Jiri Olsa [this message]
2019-10-15 5:33 ` [PATCH v2 2/5] perf util: Count the total cycles of all samples Jin Yao
2019-10-15 5:33 ` [PATCH v2 3/5] perf report: Sort by sampled cycles percent per block for stdio Jin Yao
2019-10-15 8:41 ` Jiri Olsa
2019-10-15 14:53 ` Jin, Yao
2019-10-16 10:15 ` Jiri Olsa
2019-10-16 10:51 ` Jin, Yao
2019-10-16 12:53 ` Jiri Olsa
2019-10-16 13:09 ` Jin, Yao
2019-10-21 6:56 ` Jin, Yao
2019-10-21 14:04 ` Jiri Olsa
2019-10-21 16:07 ` Jiri Olsa
2019-10-21 16:07 ` Jiri Olsa
2019-10-22 0:57 ` Jin, Yao
2019-10-21 16:08 ` Jiri Olsa
2019-10-22 1:04 ` Jin, Yao
2019-10-15 5:33 ` [PATCH v2 4/5] perf report: Support --percent-limit for total_cycles Jin Yao
2019-10-15 5:33 ` [PATCH v2 5/5] perf report: Sort by sampled cycles percent per block for tui Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021160811.GI32718@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox