From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D6DCA9EAF for ; Mon, 21 Oct 2019 14:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76DC720656 for ; Mon, 21 Oct 2019 14:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729483AbfJUOxH (ORCPT ); Mon, 21 Oct 2019 10:53:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:49456 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727771AbfJUOxG (ORCPT ); Mon, 21 Oct 2019 10:53:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EA946ADBF; Mon, 21 Oct 2019 14:53:04 +0000 (UTC) Date: Mon, 21 Oct 2019 16:53:21 +0200 From: Jean Delvare To: "Erwan Velu" Cc: "Robert P. J. Day" , "Erwan Velu" , "David S. Miller" , "Changbin Du" , "Boris Brezillon" , "Mauro Carvalho Chehab" , "Sumit Garg" , "Andy Shevchenko" , "Michal Marek" , "Mattias Jacobsson" <2pi@mok.nu>, "Masahiro Yamada" , , Subject: Re: [PATCH 2/3] firmware/dmi: Report DMI Bios release Message-ID: <20191021165321.60be88cd@endymion> In-Reply-To: <20190918094323.17515-2-e.velu@criteo.com> References: <20190918094323.17515-1-e.velu@criteo.com> <20190918094323.17515-2-e.velu@criteo.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Sep 2019 11:43:20 +0200, Erwan Velu wrote: > Some vendors like HPe or Dell, encodes the release version of their BIOS encodes -> encode > in the "System BIOS {Major|Minor} Release" fields of Type 0. > > This information is useful to know which release of the bios is actually running. > It could be used for some quirks, debugging sessions or inventory tasks. > > This patch extract these 2 fields in DMI_BIOS_MAJOR_RELEASE & DMI_BIOS_MINOR_RELEASE. > > A typical output for a Dell system running the 65.27 bios is : > > [root@t1700 ~]# cat /sys/devices/virtual/dmi/id/bios_release_major > 65 > [root@t1700 ~]# cat /sys/devices/virtual/dmi/id/bios_release_minor > 27 > [root@t1700 ~]# I don't think we want two fields. This adds quite some overhead, and they are not independent from each other anyway. I'd rather have one field with the values combined: [root@t1700 ~]# cat /sys/devices/virtual/dmi/id/bios_release 65.27 [root@t1700 ~]# This would also be in line with how it was implemented in dmidecode. Is there any reason to NOT go that route? -- Jean Delvare SUSE L3 Support