Re: [PATCH 1/7] dt-bindings: gpu: pvrsgx: add initial bindings

Rob Herring
2019-10-21T15:08:07Z

On Fri, Oct 18, 2019 at 1:46 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> The Imagination PVR/SGX GPU is part of several SoC from
> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo
> and others.
>
> Here we describe how the SGX processor is interfaced to
> the SoC (registers, interrupt etc.).
>
> Clock, Reset and power management should be handled
> by the parent node.

That's TI specific.

>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> .../devicetree/bindings/gpu/img,pvrsgx.txt | 76 +++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/img,pvrsgx.txt

Please make this DT schema format.

> diff --git a/Documentation/devicetree/bindings/gpu/img,pvrsgx.txt b/Documentation/devicetree/bindings/gpu/img,pvrsgx.txt
> new file mode 100644
> index 000000000000..4ad87c075791
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/img,pvrsgx.txt
> @@ -0,0 +1,76 @@
> +Imagination PVR/SGX GPU
> +
> +Only the Imagination SGX530, SGX540 and SGX544 GPUs are currently covered by this binding.
> +
> +Required properties:
> +- compatible: Should be one of
> + "img,sgx530-121", "img,sgx530", "ti,omap-omap3-sgx530-121";
> + - BeagleBoard ABC, OpenPandora 600MHz
> + "img,sgx530-125", "img,sgx530", "ti,omap-omap3-sgx530-125";
> + - BeagleBoard XM, GTA04, OpenPandora 1GHz
> + "img,sgx530-125", "img,sgx530", "ti,omap-am3517-sgx530-125";
> + "img,sgx530-125", "img,sgx530", "ti,omap-am335x-sgx530-125";
> + - BeagleBone Black
> + "img,sgx540-120", "img,sgx540", "ti,omap-omap4-sgx540-120";
> + - Pandaboard (ES)
> + "img,sgx544-112", "img,sgx544", "ti,omap-omap4-sgx544-112";
> + "img,sgx544-116", "img,sgx544", "ti,omap-omap5-sgx544-116";
> + - OMAP5 UEVM, Pyra Handheld
> + "img,sgx544-116", "img,sgx544", "ti,omap-dra7-sgx544-116";

The order here is wrong. Should be most specific first.

Drop 'omap-' from the compatible.

> +
> + For further study:
> + "ti,omap-am3517-sgx530-?"
> + "ti,omap-am43xx-sgx530-?"
> + "ti,ti43xx-sgx"
> + "ti,ti81xx-sgx"
> + "img,jz4780-sgx5??-?"
> + "intel,poulsbo-sgx?"
> + "intel,cedarview-sgx?"
> + "sunxi,sgx-544-?" - Banana-Pi-M3 (Allwinner A83T)

Just drop these.

> +
> + The "ti,omap..." entries are needed temporarily to handle SoC
> + specific builds of the kernel module.
> +
> + In the long run, only the "img,sgx..." entry should suffice
> + to match a generic driver for all architectures and driver
> + code can dynamically find out on which SoC it is running.

Drop this. Which compatible an OS matches on is not relevant to the
binding. And 'temporarily' is wrong as the SoC specific compatible
strings are what are used for handling errata or other integration
specific things.

> +
> +
> +- reg: Physical base addresses and lengths of the register areas.

How many?

> +- reg-names: Names for the register areas.

If only 1 as the example suggests, then you don't need this.

> +- interrupts: The interrupt numbers.
> +
> +Optional properties:
> +- timer: the timer to be used by the driver.

Needs a better description and vendor prefix at least.

Why is this needed rather than using the OS's timers?

> +- img,cores: number of cores. Defaults to <1>.

Not discoverable?

> +
> +/ {
> + ocp {
> + sgx_module: target-module@56000000 {

This is TI specific and this binding covers other chips in theory at
least. This part is outside the scope

> + compatible = "ti,sysc-omap4", "ti,sysc";
> + reg = <0x5600fe00 0x4>,
> + <0x5600fe10 0x4>;

How does it work that these registers overlap the GPU registers?

> + reg-names = "rev", "sysc";
> + ti,sysc-midle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + clocks = <&gpu_clkctrl OMAP5_GPU_CLKCTRL 0>;
> + clock-names = "fck";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x56000000 0x2000000>;
> +
> + sgx@fe00 {

gpu@...

> + compatible = "img,sgx544-116", "img,sgx544", "ti,omap-omap5-sgx544-116";
> + reg = <0xfe00 0x200>;
> + reg-names = "sgx";
> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> + timer = <&timer11>;
> + img,cores = <2>;
> + };
> + };
> + };
> +};
> --
> 2.19.1
>