Re: [PATCH] mm, meminit: Recalculate pcpu batch and high limits after init completes -fix

David Hildenbrand
2019-10-23T08:57:12Z

On 23.10.19 10:47, Mel Gorman wrote:
> LKP reported the following build problem from two hunks that did not
> survive the reshuffling of the series reordering.
>
> ld: mm/page_alloc.o: in function `page_alloc_init_late':
> mm/page_alloc.c:1956: undefined reference to `zone_pcp_update'
>
> This is a fix for the mmotm patch
> mm-meminit-recalculate-pcpu-batch-and-high-limits-after-init-completes.patch
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f9488efff680..12f3ce09d33d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -8627,7 +8627,6 @@ void free_contig_range(unsigned long pfn, unsigned int nr_pages)
> WARN(count != 0, "%d pages are still in use!\n", count);
> }
>
> -#ifdef CONFIG_MEMORY_HOTPLUG
> /*
> * The zone indicated has a new number of managed_pages; batch sizes and percpu
> * page high values need to be recalulated.
> @@ -8638,7 +8637,6 @@ void __meminit zone_pcp_update(struct zone *zone)
> __zone_pcp_update(zone);
> mutex_unlock(&pcp_batch_high_lock);
> }
> -#endif
>
> void zone_pcp_reset(struct zone *zone)
> {
>

Acked-by: David Hildenbrand <david@redhat.com>

--

Thanks,

David / dhildenb