* [PATCH] cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
@ 2019-10-22 8:43 Ben Dooks (Codethink)
2019-10-22 8:47 ` Sudeep Holla
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-22 8:43 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks (Codethink), Sudeep Holla, linux-kernel, gregkh
The parse_acpi_topology() is not declared anywhere which
causes the following sparse warning:
drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org
---
include/linux/arch_topology.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
index 42f2b5126094..3015ecbb90b1 100644
--- a/include/linux/arch_topology.h
+++ b/include/linux/arch_topology.h
@@ -57,6 +57,7 @@ const struct cpumask *cpu_coregroup_mask(int cpu);
void update_siblings_masks(unsigned int cpu);
void remove_cpu_topology(unsigned int cpuid);
void reset_cpu_topology(void);
+int parse_acpi_topology(void);
#endif
#endif /* _LINUX_ARCH_TOPOLOGY_H_ */
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
2019-10-22 8:43 [PATCH] cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h> Ben Dooks (Codethink)
@ 2019-10-22 8:47 ` Sudeep Holla
2019-10-22 17:34 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2019-10-22 8:47 UTC (permalink / raw)
To: Ben Dooks (Codethink), gregkh; +Cc: linux-kernel, linux-kernel
On Tue, Oct 22, 2019 at 09:43:23AM +0100, Ben Dooks (Codethink) wrote:
> The parse_acpi_topology() is not declared anywhere which
> causes the following sparse warning:
>
> drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Hi Greg,
Can you pick this up ? Thanks.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
2019-10-22 8:47 ` Sudeep Holla
@ 2019-10-22 17:34 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-10-22 17:34 UTC (permalink / raw)
To: Sudeep Holla; +Cc: Ben Dooks (Codethink), linux-kernel, linux-kernel
On Tue, Oct 22, 2019 at 09:47:21AM +0100, Sudeep Holla wrote:
> On Tue, Oct 22, 2019 at 09:43:23AM +0100, Ben Dooks (Codethink) wrote:
> > The parse_acpi_topology() is not declared anywhere which
> > causes the following sparse warning:
> >
> > drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
> >
> > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> > ---
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Hi Greg,
>
> Can you pick this up ? Thanks.
Ok, I'll add it to the queue, give me a week to get to it, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-22 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-22 8:43 [PATCH] cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h> Ben Dooks (Codethink)
2019-10-22 8:47 ` Sudeep Holla
2019-10-22 17:34 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox