From: Puma Hsu <pumahsu@google.com>
To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org
Cc: badhri@google.com, kyletso@google.com, albertccwang@google.com,
rickyniu@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Puma Hsu <pumahsu@google.com>
Subject: [PATCH V2] usb: typec: Add sysfs node to show connector orientation
Date: Tue, 22 Oct 2019 16:59:24 +0800 [thread overview]
Message-ID: <20191022085924.92783-1-pumahsu@google.com> (raw)
Export the Type-C connector orientation so that user space
can get this information.
Signed-off-by: Puma Hsu <pumahsu@google.com>
---
Documentation/ABI/testing/sysfs-class-typec | 11 +++++++++++
drivers/usb/typec/class.c | 18 ++++++++++++++++++
2 files changed, 29 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-class-typec b/Documentation/ABI/testing/sysfs-class-typec
index d7647b258c3c..b22f71801671 100644
--- a/Documentation/ABI/testing/sysfs-class-typec
+++ b/Documentation/ABI/testing/sysfs-class-typec
@@ -108,6 +108,17 @@ Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Description:
Revision number of the supported USB Type-C specification.
+What: /sys/class/typec/<port>/connector_orientation
+Date: October 2019
+Contact: Puma Hsu <pumahsu@google.com>
+Description:
+ Indicates which typec connector orientation is configured now.
+ cc1 is defined as "normal" and cc2 is defined as "reversed".
+
+ Valid value:
+ - unknown (nothing configured)
+ - normal (configured in cc1 side)
+ - reversed (configured in cc2 side)
USB Type-C partner devices (eg. /sys/class/typec/port0-partner/)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 94a3eda62add..911d06676aeb 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -1245,6 +1245,23 @@ static ssize_t usb_power_delivery_revision_show(struct device *dev,
}
static DEVICE_ATTR_RO(usb_power_delivery_revision);
+static const char * const typec_connector_orientation[] = {
+ [TYPEC_ORIENTATION_NONE] = "unknown",
+ [TYPEC_ORIENTATION_NORMAL] = "normal",
+ [TYPEC_ORIENTATION_REVERSE] = "reversed",
+};
+
+static ssize_t connector_orientation_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct typec_port *p = to_typec_port(dev);
+
+ return sprintf(buf, "%s\n",
+ typec_connector_orientation[p->orientation]);
+}
+static DEVICE_ATTR_RO(connector_orientation);
+
static struct attribute *typec_attrs[] = {
&dev_attr_data_role.attr,
&dev_attr_power_operation_mode.attr,
@@ -1255,6 +1272,7 @@ static struct attribute *typec_attrs[] = {
&dev_attr_usb_typec_revision.attr,
&dev_attr_vconn_source.attr,
&dev_attr_port_type.attr,
+ &dev_attr_connector_orientation.attr,
NULL,
};
ATTRIBUTE_GROUPS(typec);
--
2.23.0.866.gb869b98d4c-goog
next reply other threads:[~2019-10-22 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 8:59 Puma Hsu [this message]
2019-10-22 17:27 ` [PATCH V2] usb: typec: Add sysfs node to show connector orientation Greg KH
2019-10-23 3:26 ` Puma Hsu
2019-10-23 8:32 ` Heikki Krogerus
2019-10-23 13:44 ` Guenter Roeck
2019-10-23 13:53 ` Puma Hsu
2019-10-23 14:29 ` Heikki Krogerus
2019-10-23 15:01 ` Guenter Roeck
2019-10-23 15:57 ` Heikki Krogerus
2019-10-24 9:02 ` Puma Hsu
2019-10-24 12:06 ` Heikki Krogerus
2019-10-25 6:46 ` Puma Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022085924.92783-1-pumahsu@google.com \
--to=pumahsu@google.com \
--cc=albertccwang@google.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rickyniu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox