From: Roman Gushchin <guro@fb.com>
To: Hao Lee <haolee.swjtu@gmail.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"shakeelb@google.com" <shakeelb@google.com>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"chris@chrisdown.name" <chris@chrisdown.name>,
"yang.shi@linux.alibaba.com" <yang.shi@linux.alibaba.com>,
"tj@kernel.org" <tj@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: fix comments based on per-node memcg
Date: Tue, 22 Oct 2019 16:10:30 +0000 [thread overview]
Message-ID: <20191022161025.GC21381@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <20191022150618.GA15519@haolee.github.io>
On Tue, Oct 22, 2019 at 03:06:18PM +0000, Hao Lee wrote:
> These comments should be updated as memcg limit enforcement has been moved
> from zones to nodes.
>
> Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
> ---
> include/linux/memcontrol.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index ae703ea3ef48..12c29f74c02a 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -112,7 +112,7 @@ struct memcg_shrinker_map {
> };
>
> /*
> - * per-zone information in memory controller.
> + * per-node information in memory controller.
> */
> struct mem_cgroup_per_node {
> struct lruvec lruvec;
> @@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
> * @memcg: memcg of the wanted lruvec
> *
> * Returns the lru list vector holding pages for a given @node or a given
> - * @memcg and @zone. This can be the node lruvec, if the memory controller
> - * is disabled.
> + * @memcg. This can be the node lruvec, if the memory controller is disabled.
> */
> static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
> struct mem_cgroup *memcg)
> --
> 2.14.5
>
next prev parent reply other threads:[~2019-10-22 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 15:06 [PATCH] mm: fix comments based on per-node memcg Hao Lee
2019-10-22 16:10 ` Roman Gushchin [this message]
2019-10-22 17:06 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022161025.GC21381@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=haolee.swjtu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox