From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0286CA9EB7 for ; Tue, 22 Oct 2019 19:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB889214B2 for ; Tue, 22 Oct 2019 19:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388636AbfJVTmd (ORCPT ); Tue, 22 Oct 2019 15:42:33 -0400 Received: from www62.your-server.de ([213.133.104.62]:46196 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731806AbfJVTmd (ORCPT ); Tue, 22 Oct 2019 15:42:33 -0400 Received: from 13.249.197.178.dynamic.dsl-lte-bonding.lssmb00p-msn.res.cust.swisscom.ch ([178.197.249.13] helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iN030-0005QE-Ii; Tue, 22 Oct 2019 21:42:26 +0200 Date: Tue, 22 Oct 2019 21:42:26 +0200 From: Daniel Borkmann To: "Ben Dooks (Codethink)" Cc: linux-kernel@lists.codethink.co.uk, Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Steven Rostedt , Ingo Molnar , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xdp: fix type of string pointer in __XDP_ACT_SYM_TAB Message-ID: <20191022194226.GD31343@pc-66.home> References: <20191022125925.10508-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022125925.10508-1-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25610/Tue Oct 22 10:54:26 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 01:59:25PM +0100, Ben Dooks (Codethink) wrote: > The table entry in __XDP_ACT_SYM_TAB for the last item is set > to { -1, 0 } where it should be { -1, NULL } as the second item > is a pointer to a string. > > Fixes the following sparse warnings: > > ./include/trace/events/xdp.h:28:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:53:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:82:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:140:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:155:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:190:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:225:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:260:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:318:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:356:1: warning: Using plain integer as NULL pointer > ./include/trace/events/xdp.h:390:1: warning: Using plain integer as NULL pointer > > Signed-off-by: Ben Dooks (Codethink) Applied, thanks!