AW: [PATCH 0/8] Face lift for st1232 touchscreen driver

Matthias Fend
2019-10-28T07:28:58Z

Hi Dmitry,

> -----Ursprüngliche Nachricht-----
> Von: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Gesendet: Dienstag, 22. Oktober 2019 21:56
> An: Martin Kepplinger <martink@posteo.de>
> Cc: Dixit Parmar <dixitparmar19@gmail.com>; Henrik Rydberg
> <rydberg@bitmath.org>; Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com>; Matthias Fend
> <Matthias.Fend@wolfvision.net>; linux-input@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Betreff: [PATCH 0/8] Face lift for st1232 touchscreen driver
>
> This series cleans up the driver and switches it over to the slotted
> multi-touch protocol (MT-B) that should reduce the traffic between kernel
> and userspace.
>
> Note that I do not have hardware, so I would appreciate if you could try
> running it and tell me if it is broken or not.

Looks good. I tested the series from your st1232 branch [1] and could not see any regressions.
Note that I my 'real' application only supports ONE finger. So, the other fingers are just tested with debug output.

Thanks,
~Matthias

[1] git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git st1232

>
> Thanks!
>
>
> Dmitry Torokhov (8):
> Input: st1232 - simplify parsing of read buffer
> Input: st1232 - do not unconditionally configure as wakeup source
> Input: st1232 - rely on I2C core to configure wakeup interrupt
> Input: st1232 - do not reset the chip too early
> Input: st1232 - do not allocate fingers data separately
> Input: st1232 - do not set parent device explicitly
> Input: st1232 - note that the receive buffer is DMA-safe
> Input: st1232 - switch to using MT-B protocol
>
> drivers/input/touchscreen/st1232.c | 184 ++++++++++++++---------------
> 1 file changed, 89 insertions(+), 95 deletions(-)
>
> --
> 2.23.0.866.gb869b98d4c-goog