From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D28CA9EB9 for ; Wed, 23 Oct 2019 06:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A64DA2084C for ; Wed, 23 Oct 2019 06:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571813461; bh=dtIAJSZ+/PrEmKbCaiy/wKWVXQ1MTr81bajpc714TM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EoDPEPhv5/EqIQzaLm/9dHnbL48OXnsh7YAmR/0bllhUKWM3lbX6d+bhlQVj0ryrR 3qdLIRsrFG2OU9zuzjN11x/R0Rp6X0G/VYFkFuGv1LGVYW5duPn1dX+S1LI/+W5HKS AYT2IoGpuygwSJtjqLKxmEYoUFKC8XrM0eGoTVuQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389465AbfJWGvA (ORCPT ); Wed, 23 Oct 2019 02:51:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:41002 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727194AbfJWGvA (ORCPT ); Wed, 23 Oct 2019 02:51:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9B113B549; Wed, 23 Oct 2019 06:50:58 +0000 (UTC) Date: Wed, 23 Oct 2019 08:50:57 +0200 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] mm: memcontrol: remove dead code from memory_max_write() Message-ID: <20191023065057.GC754@dhcp22.suse.cz> References: <20191022201518.341216-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022201518.341216-1-hannes@cmpxchg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 22-10-19 16:15:17, Johannes Weiner wrote: > When the reclaim loop in memory_max_write() is ^C'd or similar, we set > err to -EINTR. But we don't return err. Once the limit is set, we > always return success (nbytes). Delete the dead code. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > mm/memcontrol.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 055975b0b3a3..ff90d4e7df37 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -6122,10 +6122,8 @@ static ssize_t memory_max_write(struct kernfs_open_file *of, > if (nr_pages <= max) > break; > > - if (signal_pending(current)) { > - err = -EINTR; > + if (signal_pending(current)) > break; > - } > > if (!drained) { > drain_all_stock(memcg); > -- > 2.23.0 > -- Michal Hocko SUSE Labs