Re: [PATCH 11/36] ARM: s5pv210: split from plat-samsung

Uwe Kleine-König
2019-10-22T15:53:52Z

Hello,

On Tue, Oct 22, 2019 at 04:01:12PM +0200, Arnd Bergmann wrote:
> > > @@ -235,7 +235,6 @@ machine-$(CONFIG_PLAT_SPEAR) += spear
> > > # by CONFIG_* macro name.
> > > plat-$(CONFIG_ARCH_OMAP) += omap
> > > plat-$(CONFIG_ARCH_S3C64XX) += samsung
> > > -plat-$(CONFIG_ARCH_S5PV210) += samsung
> >
> > Would it make more sense to make this
> >
> > plat-$(PLAT_SAMSUNG) += samsung
> >
> > (in a separate patch)? Hmm, it seems there is no plat-y for
> > PLAT_S3C24XX=y builds. Is this intended? If yes, the directory name
> > containing "samsung" suggests something that seems untrue.
>
> By the end of the series, the plat-samsung directory is completely
> removed (folded into mach-s3c), so that would only add more
> churn for the same result I think.

fine for me. The background of my question was me wondering if builds
for PLAT_S3C24XX=y (before your patch series) don't need plat-samsung.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |