Re: [PATCH 08/36] ARM: exynos: stop selecting PLAT_SAMSUNG

Arnd Bergmann
2019-10-23T12:43:57Z

On Wed, Oct 23, 2019 at 12:57 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Oct 10, 2019 at 10:29:52PM +0200, Arnd Bergmann wrote:
> > @@ -1022,7 +1022,7 @@ choice
> > by the boot-loader before use.
> >
> > config DEBUG_S3C_UART2
> > - depends on PLAT_SAMSUNG
> > + depends on PLAT_SAMSUNG || ARCH_EXYNOS
> > select DEBUG_EXYNOS_UART if ARCH_EXYNOS
> > select DEBUG_S3C24XX_UART if ARCH_S3C24XX
> > select DEBUG_S3C64XX_UART if ARCH_S3C64XX
> > @@ -1034,7 +1034,7 @@ choice
> > by the boot-loader before use.
> >
> > config DEBUG_S3C_UART3
> > - depends on PLAT_SAMSUNG && (ARCH_EXYNOS || ARCH_S5PV210)
> > + depends on ARCH_EXYNOS || ARCH_S5PV210
>
> You need to keep PLAT_SAMSUNG because of additional architectures, so
> follow pattern from DEBUG_S3C_UART2.

Are you sure? I think my version is correct: for UART2, the
"PLAT_SAMSUNG || ARCH_EXYNOS" is equivalent to "s3c24xx || s3c64xx ||
s5pv210 || exynos", which keeps the existing behavior unchanged.

For UART3, the "PLAT_SAMSUNG && ..." is redundant, this is already
limited to "s5pv210 || exynos", which my patch keeps. Changing it to
"PLAT_SAMSUNG || ..." would allow selecting the symbol on s3c24xx
and s3c64xx, which presumably is not valid.

Arnd