Re: [PATCH 21/36] ARM: s3c: move iis pinctrl config into boards

Krzysztof Kozlowski
2019-10-23T12:51:00Z

On Thu, Oct 10, 2019 at 10:30:05PM +0200, Arnd Bergmann wrote:
> The s3c_gpio_cfgall_range() function is an internal interface of
> the samsung gpio driver and should not be called directly by drivers,
> so move the iis pin initialization into the boards.
>
> Note that the s3c2412-i2s driver has no boards using it in
> mainline linux, the driver gets selected for the jive machine
> but is never instantiated.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-s3c24xx/mach-gta02.c | 4 ++++
> arch/arm/mach-s3c24xx/mach-h1940.c | 3 +++
> arch/arm/mach-s3c24xx/mach-mini2440.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-n30.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-nexcoder.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-otom.c | 6 ++++++
> arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +++
> arch/arm/mach-s3c24xx/mach-rx1950.c | 3 +++
> arch/arm/mach-s3c24xx/mach-rx3715.c | 4 ++++
> arch/arm/mach-s3c24xx/mach-smdk2410.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-smdk2413.c | 4 ++++
> arch/arm/mach-s3c24xx/mach-smdk2440.c | 6 +++++-
> arch/arm/mach-s3c24xx/mach-vstms.c | 6 +++++-
> arch/arm/mach-s3c24xx/simtec-audio.c | 6 ++++++
> sound/soc/samsung/s3c2412-i2s.c | 7 -------
> sound/soc/samsung/s3c24xx-i2s.c | 7 -------
> 16 files changed, 63 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c
> index 526fd0933289..1ca0460d82f4 100644
> --- a/arch/arm/mach-s3c24xx/mach-gta02.c
> +++ b/arch/arm/mach-s3c24xx/mach-gta02.c
> @@ -540,6 +540,10 @@ static void __init gta02_machine_init(void)
>
> i2c_register_board_info(0, gta02_i2c_devs, ARRAY_SIZE(gta02_i2c_devs));
>
> + /* Configure the I2S pins (GPE0...GPE4) in correct mode */
> + s3c_gpio_cfgall_range(S3C2410_GPE(0), 5, S3C_GPIO_SFN(2),
> + S3C_GPIO_PULL_NONE);

This is not entirely equivalent move as before this was probe (so being
executed also on rebinds) and now it is init. I guess it should not make
any difference so let it be.

Best regards,
Krzysztof