Re: [PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency

Arnd Bergmann
2019-10-23T13:36:10Z

On Wed, Oct 23, 2019 at 3:13 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Oct 10, 2019 at 10:30:12PM +0200, Arnd Bergmann wrote:

> > @@ -321,6 +320,7 @@ static struct s3c2410fb_mach_info jive_lcd_config = {
> > * data. */
> >
> > .gpcup = (0xf << 1) | (0x3f << 10),
> > + .gpcup_reg = S3C2410_GPCUP,
>
> Nits: indentation before/after '=' looks wrong. Tab should be
> before '=', one space after.

Ok, fixed now for the four boards that had inconsistent indentation --
jive, mini2440, smdk2440, and rx1950. Unfortunately each board
seemed to have its own way of doing this.

Arnd