From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
mingo@elte.hu, Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>, "Liang, Kan" <kan.liang@intel.com>,
Song Liu <songliubraving@fb.com>, Ian Rogers <irogers@google.com>
Subject: Re: [PATCH] perf/core: fix multiplexing event scheduling issue
Date: Wed, 23 Oct 2019 17:29:20 +0200 [thread overview]
Message-ID: <20191023152920.GG19358@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191023093757.GR1817@hirez.programming.kicks-ass.net>
On Wed, Oct 23, 2019 at 11:37:57AM +0200, Peter Zijlstra wrote:
> Further, since we set it on reschedule, I propose you change the above
> like:
>
> if (ctx->rotate_necessary) {
> int type = get_event_type(event);
> /*
> * comment..
> */
> if (type & EVENT_PINNED)
> type |= EVENT_FLEXIBLE;
> + /*
> + * Will be reset by ctx_resched()'s flexible_sched_in().
> + */
> + ctx->rotate_necessary = 0;
> ctx_resched(cpuctx, cpuctx->task_ctx, type);
> }
n/m, that is already done through ctx_sched_out().
next prev parent reply other threads:[~2019-10-23 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:27 [PATCH] perf/core: fix multiplexing event scheduling issue Stephane Eranian
2019-10-18 6:13 ` Song Liu
2019-10-18 6:19 ` Stephane Eranian
2019-10-18 6:55 ` Song Liu
2019-10-21 10:05 ` Peter Zijlstra
2019-10-23 7:06 ` Stephane Eranian
2019-10-23 9:37 ` Peter Zijlstra
2019-10-23 15:29 ` Peter Zijlstra [this message]
2019-10-21 10:20 ` Peter Zijlstra
2019-10-23 7:30 ` Stephane Eranian
2019-10-23 11:02 ` Peter Zijlstra
2019-10-23 17:44 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023152920.GG19358@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox