Re: [PATCH 1/4] dt-bindings: arm: Initial MStar vendor prefixes and compatible strings

Daniel Palmer
2019-10-23T22:44:08Z

On Wed, Oct 23, 2019 at 03:02:28PM -0500, Rob Herring wrote:
> > +# SPDX-License-Identifier: (GPL-2.0+ OR X11)
>
> (GPL-2.0-only OR BSD-2-Clause) is preferred. Any reason to differ?

I used the sunxi file as a template and thought they had some
reason to do that. I'll change it to just GPL-2.0.

> > + - description: thingy.jp BreadBee
> > + items:
> > + - const: thingyjp,breadbee
> > + - const: mstar,infinity
> > + - const: mstar,infinity3
>
> infinity vs. infinity3? What's the difference? It's generally sufficient
> to just list a board compatible and a SoC compatible.

Apart from some very slight differences (max clock speed, different PWM block)
they are the same and the PCB for the BreadBee can take either the msc313(i1) or
msc313e(i3). My v2 patch will remove the mstar,infinity line from there and move
it to a second board called the breadbee-crust to handle the i1 configuration.

Thanks,

Daniel