Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode

Neil Armstrong
2019-11-12T09:00:08Z

Hi Li,

On 11/11/2019 02:58, Jun Li wrote:
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?

I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
how to handle this.

Did Synopsys specified a range of affected IP version ?

Neil

>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>
>> Thanks for working on this Neil,
>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>> As previously mentioned the patch set fixes the issue on affected hardware;
>> https://patchwork.kernel.org/patch/11164515/
>>
>>
>>
>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>
>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>> This patch updates the documentation with the information related
>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>> instances in park mode.
>>>>
>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>> Reported-by: Tim <elatllat@gmail.com>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>
>>> Sigh, what's one more to the never ending list of quirks...
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>