From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH 0/3] perf/probe: Fix available line bugs
Date: Thu, 24 Oct 2019 10:43:25 -0300 [thread overview]
Message-ID: <20191024134325.GA1666@kernel.org> (raw)
In-Reply-To: <157190834681.1859.7399361844806238387.stgit@devnote2>
Em Thu, Oct 24, 2019 at 06:12:27PM +0900, Masami Hiramatsu escreveu:
> Hi,
>
> Here are some bugfixes related to showing available line (--line/-L)
> option. I found that gcc generated some subprogram DIE with only
> range attribute but no entry_pc or low_pc attributes.
> In that case, perf probe failed to show the available lines in that
> subprogram (function). To fix that, I introduced some bugfixes to
> handle such cases correctly.
Thanks, applied, next time please provide concrete examples for things
that don't work before and gets fixed with your patches, this way we can
more easily reproduce your steps.
- Arnaldo
> Thank you,
>
> ---
>
> Masami Hiramatsu (3):
> perf/probe: Fix to find range-only function instance
> perf/probe: Walk function lines in lexical blocks
> perf/probe: Fix to show function entry line as probe-able
>
>
> tools/perf/util/dwarf-aux.c | 44 ++++++++++++++++++++++++++++++++++++-------
> tools/perf/util/dwarf-aux.h | 3 +++
> 2 files changed, 40 insertions(+), 7 deletions(-)
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
--
- Arnaldo
next prev parent reply other threads:[~2019-10-24 13:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 9:12 [BUGFIX PATCH 0/3] perf/probe: Fix available line bugs Masami Hiramatsu
2019-10-24 9:12 ` [BUGFIX PATCH 1/3] perf/probe: Fix to find range-only function instance Masami Hiramatsu
2019-11-12 11:18 ` [tip: perf/core] perf probe: " tip-bot2 for Masami Hiramatsu
2019-10-24 9:12 ` [BUGFIX PATCH 2/3] perf/probe: Walk function lines in lexical blocks Masami Hiramatsu
2019-11-12 11:18 ` [tip: perf/core] perf probe: " tip-bot2 for Masami Hiramatsu
2019-10-24 9:12 ` [BUGFIX PATCH 3/3] perf/probe: Fix to show function entry line as probe-able Masami Hiramatsu
2019-11-12 11:18 ` [tip: perf/core] perf probe: " tip-bot2 for Masami Hiramatsu
2019-10-24 13:43 ` Arnaldo Carvalho de Melo [this message]
2019-10-24 15:36 ` [BUGFIX PATCH 0/3] perf/probe: Fix available line bugs Masami Hiramatsu
2019-10-24 20:23 ` Arnaldo Carvalho de Melo
2019-10-24 23:22 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024134325.GA1666@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox