Re: [PATCH 04/15] staging: exfat: Clean up return codes - FFS_PERMISSIONERR

Joe Perches
2019-10-24T16:23:38Z

On Thu, 2019-10-24 at 11:53 -0400, Valdis Kletnieks wrote:
> Convert FFS_PERMISSIONERR to -EPERM
[]
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
[]
> @@ -2526,7 +2526,7 @@ static int exfat_unlink(struct inode *dir, struct dentry *dentry)
>
> err = ffsRemoveFile(dir, &(EXFAT_I(inode)->fid));
> if (err) {
> - if (err == FFS_PERMISSIONERR)
> + if (err == -EPERM)
> err = -EPERM;
> else
> err = -EIO;
[]
> @@ -2746,7 +2746,7 @@ static int exfat_rename(struct inode *old_dir, struct dentry *old_dentry,
> err = ffsMoveFile(old_dir, &(EXFAT_I(old_inode)->fid), new_dir,
> new_dentry);
> if (err) {
> - if (err == FFS_PERMISSIONERR)
> + if (err == -EPERM)
> err = -EPERM;
> else if (err == FFS_INVALIDPATH)
> err = -EINVAL;

These test and assign to same value blocks look kinda silly.