From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrey Zhizhikin <andrey.z@gmail.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, lee.jones@linaro.org,
linux-kernel@vger.kernel.org,
Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Subject: Re: [PATCH 0/2] add regulator driver and mfd cell for Intel Cherry Trail Whiskey Cove PMIC
Date: Fri, 25 Oct 2019 10:53:35 +0300 [thread overview]
Message-ID: <20191025075335.GC32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191024142939.25920-1-andrey.zhizhikin@leica-geosystems.com>
On Thu, Oct 24, 2019 at 02:29:37PM +0000, Andrey Zhizhikin wrote:
> This patchset introduces additional regulator driver for Intel Cherry
> Trail Whiskey Cove PMIC. It also adds a cell in mfd driver for this
> PMIC, which is used to instantiate this regulator.
>
> Regulator support for this PMIC was present in kernel release from Intel
> targeted Aero platform, but was not entirely ported upstream and has
> been omitted in mainline kernel releases. Consecutively, absence of
> regulator caused the SD Card interface not to be provided with Vqcc
> voltage source needed to operate with UHS-I cards.
>
> Following patches are addessing this issue and making sd card interface
> to be fully operable with UHS-I cards. Regulator driver lists an ACPI id
> of the SD Card interface in consumers and exposes optional "vqmmc"
> voltage source, which mmc driver uses to switch signalling voltages
> between 1.8V and 3.3V.
>
> This set contains of 2 patches: one is implementing the regulator driver
> (based on a non upstreamed version from Intel Aero), and another patch
> registers this driver as mfd cell in exising Whiskey Cove PMIC driver.
Thank you.
Hans, Cc'ed, has quite interested in these kind of patches.
Am I right, Hans?
>
>
> Andrey Zhizhikin (2):
> regulator: add support for Intel Cherry Whiskey Cove regulator
> mfd: add regulator cell to Cherry Trail Whiskey Cove PMIC
>
> drivers/mfd/intel_soc_pmic_chtwc.c | 15 +-
> drivers/regulator/Kconfig | 10 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/intel-cht-wc-regulator.c | 433 ++++++++++++++++++
> .../linux/regulator/intel-cht-wc-regulator.h | 64 +++
> 5 files changed, 521 insertions(+), 2 deletions(-)
> create mode 100644 drivers/regulator/intel-cht-wc-regulator.c
> create mode 100644 include/linux/regulator/intel-cht-wc-regulator.h
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-25 7:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 14:29 [PATCH 0/2] add regulator driver and mfd cell for Intel Cherry Trail Whiskey Cove PMIC Andrey Zhizhikin
2019-10-24 14:29 ` [PATCH 1/2] regulator: add support for Intel Cherry Whiskey Cove regulator Andrey Zhizhikin
2019-10-25 8:01 ` Andy Shevchenko
2019-10-25 8:58 ` Andrey Zhizhikin
2019-10-25 9:14 ` Andy Shevchenko
2019-10-25 9:31 ` Andrey Zhizhikin
2019-10-25 10:47 ` Andy Shevchenko
2019-10-25 12:17 ` Mark Brown
2019-10-25 15:26 ` Andrey Zhizhikin
2019-10-25 16:02 ` Andy Shevchenko
2019-10-25 16:21 ` Andrey Zhizhikin
2019-10-24 14:29 ` [PATCH 2/2] mfd: add regulator cell to Cherry Trail Whiskey Cove PMIC Andrey Zhizhikin
2019-10-25 8:06 ` Andy Shevchenko
2019-10-25 9:16 ` Andrey Zhizhikin
2019-10-25 10:49 ` Andy Shevchenko
2019-10-25 12:00 ` Andrey Zhizhikin
2019-10-25 7:53 ` Andy Shevchenko [this message]
2019-10-25 7:55 ` [PATCH 0/2] add regulator driver and mfd cell for Intel " Andy Shevchenko
2019-10-25 8:51 ` Andrey Zhizhikin
2019-10-28 12:41 ` Adrian Hunter
2019-10-28 12:45 ` Mark Brown
2019-10-28 13:26 ` Hans de Goede
2019-10-28 15:01 ` Andrey Zhizhikin
2019-10-29 12:03 ` Hans de Goede
2019-10-29 16:57 ` Andrey Zhizhikin
2019-10-29 17:14 ` Hans de Goede
2019-10-28 16:28 ` Andy Shevchenko
2019-10-28 14:40 ` Andrey Zhizhikin
2019-10-25 9:38 ` Hans de Goede
2019-10-25 10:11 ` Andrey Zhizhikin
2019-10-25 10:45 ` Hans de Goede
2019-10-25 11:54 ` Andrey Zhizhikin
2019-10-25 12:05 ` Mark Brown
2019-10-25 12:18 ` Hans de Goede
2019-10-25 10:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025075335.GC32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrey.z@gmail.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox