From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FFACA9EB9 for ; Sat, 26 Oct 2019 07:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 237EB21655 for ; Sat, 26 Oct 2019 07:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572075920; bh=s7EeSH/whkZRbX7EQncmx/wuGx/KiZ/hnCC4ldgo68A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FrAo/PKU1XIjWbvjA6D3AhROLNRPJJYJJdI3zTLEsrVcvxBsY08CAg5Z7E9x6jxHP 7s42kJ6+ou/PTOjQ48KsWfXwRL/FE+fTPoUCrFS9jZP41+nt/Bdv82SD91Q6UsQZqV 1IsbPC3GBKLLGDNb/rxMsQ1WzausB7cU1cGecZGM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726106AbfJZHov (ORCPT ); Sat, 26 Oct 2019 03:44:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:56002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbfJZHou (ORCPT ); Sat, 26 Oct 2019 03:44:50 -0400 Received: from localhost (unknown [89.205.133.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9456E21655; Sat, 26 Oct 2019 07:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572075889; bh=s7EeSH/whkZRbX7EQncmx/wuGx/KiZ/hnCC4ldgo68A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DZeYBVZFS33GY85zsXOJ+OBeYKt0+FJqwXHoA0q0OGueUdnrRqnbs/Kb9BijDMFRP a7VZe3hgv8ZocTHiWeL5Dp/683bdiU7Ovh5+AroZsu6Dq9pLPW1v7RuEhuMP+2h6jC EVE2EQsqOzoBPZgP7HmYDcTTWEY3aAl70YFfGbAU= Date: Sat, 26 Oct 2019 03:44:45 -0400 From: Greg Kroah-Hartman To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Venkata Narendra Kumar Gutta Subject: Re: [PATCH AUTOSEL 4.19 10/37] driver core: platform: Fix the usage of platform device name(pdev->name) Message-ID: <20191026074445.GA553664@kroah.com> References: <20191025135603.25093-1-sashal@kernel.org> <20191025135603.25093-10-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191025135603.25093-10-sashal@kernel.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 25, 2019 at 09:55:34AM -0400, Sasha Levin wrote: > From: Venkata Narendra Kumar Gutta > > [ Upstream commit edb16da34b084c66763f29bee42b4e6bb33c3d66 ] > > Platform core is using pdev->name as the platform device name to do > the binding of the devices with the drivers. But, when the platform > driver overrides the platform device name with dev_set_name(), > the pdev->name is pointing to a location which is freed and becomes > an invalid parameter to do the binding match. > > use-after-free instance: > > [ 33.325013] BUG: KASAN: use-after-free in strcmp+0x8c/0xb0 > [ 33.330646] Read of size 1 at addr ffffffc10beae600 by task modprobe > [ 33.339068] CPU: 5 PID: 518 Comm: modprobe Tainted: > G S W O 4.19.30+ #3 > [ 33.346835] Hardware name: MTP (DT) > [ 33.350419] Call trace: > [ 33.352941] dump_backtrace+0x0/0x3b8 > [ 33.356713] show_stack+0x24/0x30 > [ 33.360119] dump_stack+0x160/0x1d8 > [ 33.363709] print_address_description+0x84/0x2e0 > [ 33.368549] kasan_report+0x26c/0x2d0 > [ 33.372322] __asan_report_load1_noabort+0x2c/0x38 > [ 33.377248] strcmp+0x8c/0xb0 > [ 33.380306] platform_match+0x70/0x1f8 > [ 33.384168] __driver_attach+0x78/0x3a0 > [ 33.388111] bus_for_each_dev+0x13c/0x1b8 > [ 33.392237] driver_attach+0x4c/0x58 > [ 33.395910] bus_add_driver+0x350/0x560 > [ 33.399854] driver_register+0x23c/0x328 > [ 33.403886] __platform_driver_register+0xd0/0xe0 > > So, use dev_name(&pdev->dev), which fetches the platform device name from > the kobject(dev->kobj->name) of the device instead of the pdev->name. > > Signed-off-by: Venkata Narendra Kumar Gutta > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Sasha Levin > --- > drivers/base/platform.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) We had to revert this patch in commit 391c0325cc5f ("Revert "driver core: platform: Fix the usage of platform device name(pdev->name)"") so please do not backport it to any stable kernels. thanks, greg k-h