From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A313CA9EB9 for ; Sat, 26 Oct 2019 13:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3665D2070B for ; Sat, 26 Oct 2019 13:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572095836; bh=d30o/IJjeuRx2IN8/lTJ5LyPTjn9Kkv1YZ8fBNY6+0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Q9SXE9gz+sEHrAnvEZSnNo5KBNEx/oyPqUxW+KWogPUEjNOgPmGykvxWojwt7+zew 27y6m82R4EBA/p1LKsr1kqptU4uQ1rqMYVjTrtso5gLGZ20972Hja/nsgJKrxh5t9T QH3+FPCv+RZaAI3D3GcnUJgBC+kSMrd1ffQVNBPU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727232AbfJZNRP (ORCPT ); Sat, 26 Oct 2019 09:17:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:38716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727175AbfJZNRJ (ORCPT ); Sat, 26 Oct 2019 09:17:09 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A62CC21655; Sat, 26 Oct 2019 13:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572095828; bh=d30o/IJjeuRx2IN8/lTJ5LyPTjn9Kkv1YZ8fBNY6+0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xw1gT+r9h6FB9/LmIj21h1SkjEWE8Xwfx8xHsFj4STasdy2iFLI/+5loGB2qpdHXl 52nR9nMUlH9NXxoiCjqNjcuQcZy6HT4gO3/N1KFT9zCDgUDYcWXgjImxQ2MQGenUGv m92sQgL95YjyOlpYBK7yB6hOgcYI3bmmTcVgMNOs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , Luca Coelho , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.3 36/99] iwlwifi: dbg_ini: fix memory leak in alloc_sgtable Date: Sat, 26 Oct 2019 09:14:57 -0400 Message-Id: <20191026131600.2507-36-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191026131600.2507-1-sashal@kernel.org> References: <20191026131600.2507-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit b4b814fec1a5a849383f7b3886b654a13abbda7d ] In alloc_sgtable if alloc_page fails, the alocated table should be released. Signed-off-by: Navid Emamdoost Signed-off-by: Luca Coelho Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index 4d81776f576dc..db41abb3361dd 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -643,6 +643,7 @@ static struct scatterlist *alloc_sgtable(int size) if (new_page) __free_page(new_page); } + kfree(table); return NULL; } alloc_size = min_t(int, size, PAGE_SIZE); -- 2.20.1