From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 984C5CA9EB9 for ; Sat, 26 Oct 2019 13:30:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63CD9206DD for ; Sat, 26 Oct 2019 13:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572096615; bh=VkBjWB/R8bRc62N+DtBiVl/0Znyz6mpBvpCJ5F0tXVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=j7o3f8mve3tjzWvisQzNKKvUFXPpYgIXxOGwwptmO8EcqRz6sjOVWUD+SHhXvDZXO qNgqfUqWgdMcj4iWNHPo5LLbGGhwAxQlFQkLG7XbO+BIOY0mlaOt/+yrW3FZ35GnVg FORPFqmto+06AJzprJN/FMokl/Oho7o1zYYlc0sQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727112AbfJZNT4 (ORCPT ); Sat, 26 Oct 2019 09:19:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:41802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726673AbfJZNTx (ORCPT ); Sat, 26 Oct 2019 09:19:53 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A389F21D7F; Sat, 26 Oct 2019 13:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572095992; bh=VkBjWB/R8bRc62N+DtBiVl/0Znyz6mpBvpCJ5F0tXVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I1rswr2gt6VSQqiKa6kOvLA+ooBMjLvWU8KPPnv1LxkQQNoec7kC24G9dUqJhjp2q 2+gmcadPyfDCTgxaKcdYkpjnta3brgUZlcoie+nW20hNfA3BDOPMx3xBoaHV+2vLxB wgdVuvymuO5xUdKTLhJwxijmSm3JpRXgahE56Z9c= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , Luca Coelho , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 23/59] iwlwifi: dbg_ini: fix memory leak in alloc_sgtable Date: Sat, 26 Oct 2019 09:18:34 -0400 Message-Id: <20191026131910.3435-23-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191026131910.3435-1-sashal@kernel.org> References: <20191026131910.3435-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit b4b814fec1a5a849383f7b3886b654a13abbda7d ] In alloc_sgtable if alloc_page fails, the alocated table should be released. Signed-off-by: Navid Emamdoost Signed-off-by: Luca Coelho Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index a31a42e673c46..0d567cc0a2643 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -547,6 +547,7 @@ static struct scatterlist *alloc_sgtable(int size) if (new_page) __free_page(new_page); } + kfree(table); return NULL; } alloc_size = min_t(int, size, PAGE_SIZE); -- 2.20.1