From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCE07CA9EB9 for ; Sat, 26 Oct 2019 13:28:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 967B2214DA for ; Sat, 26 Oct 2019 13:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572096514; bh=r3HCFbnfyfQqTLA58/rW6Vt8nTdcXCDjlm9ZJIJV1jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ImBg0yKc9z6gIiNSU/Q+SL9FZiV/gm6pR6fIOmSV/aP06tcHM1/ZomcE/n+PntqOl YQN/2zAoq6Yu/zCoC1ee0UWPbRnCUKH3y9CZ6//V8ySo7DBQX7UI9kPWUyRabnoTr5 AYxKwadf23OY9fVaDT0MLXuUru1zgvtr6pg5jkGE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727634AbfJZN2d (ORCPT ); Sat, 26 Oct 2019 09:28:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:42656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728743AbfJZNU6 (ORCPT ); Sat, 26 Oct 2019 09:20:58 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B55E21871; Sat, 26 Oct 2019 13:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572096057; bh=r3HCFbnfyfQqTLA58/rW6Vt8nTdcXCDjlm9ZJIJV1jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=anBD0MZLBGGvv0yKSHYzSMOO46DJDP5nPsrJjQQG23oOAYayOzhVLaBYXCS1PnkhI 9t9TjXt1rE5pKufDYh9P3Qh7iiTan6R705csuPeArf/p7iUzu/vz3tMhDyc0NCDeMu hde6ck51im7c7CJn/6lgnK1NInv1XMJgZwmzHmmU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Ben Dooks (Codethink)" , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 54/59] net: stmmac: fix argument to stmmac_pcs_ctrl_ane() Date: Sat, 26 Oct 2019 09:19:05 -0400 Message-Id: <20191026131910.3435-54-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191026131910.3435-1-sashal@kernel.org> References: <20191026131910.3435-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Ben Dooks (Codethink)" [ Upstream commit c9ad4c1049f7e0e8d59e975963dda002af47d93e ] The stmmac_pcs_ctrl_ane() expects a register address as argument 1, but for some reason the mac_device_info is being passed. Fix the warning (and possible bug) from sparse: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces) drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: expected void [noderef] *ioaddr drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: got struct mac_device_info *hw Signed-off-by: Ben Dooks Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 014fe93ed2d82..15d740b6e64eb 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2558,7 +2558,7 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp) } if (priv->hw->pcs) - stmmac_pcs_ctrl_ane(priv, priv->hw, 1, priv->hw->ps, 0); + stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, priv->hw->ps, 0); /* set TX and RX rings length */ stmmac_set_rings_length(priv); -- 2.20.1