From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE058CA9EB9 for ; Sat, 26 Oct 2019 18:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD19120663 for ; Sat, 26 Oct 2019 18:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572115642; bh=ko0i0zDpitgbOfxq/GRV2PdhwP/g81WtxSssjEN3BIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AwVPNWsGWLRnHQV8GRcH+VykQ3AqDaWH7bhoWMcNpxBh/S/VpvzJYqvLtLJ91M7vN Cyzql2cOSUonlWLb3qaQqvQJmj+R71s1wi/OOR909RbXbIw5BtkfKZrycwNBFlQyh+ /V0y7qZnZeB6SkBbaqhGZwmfAv0/mFIfrh1IAXAg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbfJZSrV (ORCPT ); Sat, 26 Oct 2019 14:47:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:39844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbfJZSrV (ORCPT ); Sat, 26 Oct 2019 14:47:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F53820663; Sat, 26 Oct 2019 18:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572115638; bh=ko0i0zDpitgbOfxq/GRV2PdhwP/g81WtxSssjEN3BIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UkK5VxEy1Nj3AdQCch7Ewa4Iw8T65kQqJwVhCpf/0LHsbV0MvQHXZA/Xjo84toKA7 HZoOEHkphNJIKRxtEARPs/eYIjnnP4ibZhe9grlPF2QyoM2enBxAffKuNG21Vcv1nt kryuBnqUS8vhjvUCSN9Ab1pPeSS+/+5ilBsoQl0U= Date: Sat, 26 Oct 2019 20:47:16 +0200 From: Greg Kroah-Hartman To: Aaro Koskinen Cc: Julia Lawall , Wambui Karuga , devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon Message-ID: <20191026184716.GA753584@kroah.com> References: <20191023174304.GD18977@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023174304.GD18977@darkstar.musicnaut.iki.fi> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23, 2019 at 08:43:04PM +0300, Aaro Koskinen wrote: > Hi, > > On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote: > > On Sat, 12 Oct 2019, Wambui Karuga wrote: > > > This patchset removes the addition of new typedefs data types in octeon, > > > along with replacing the previous uses with the new declaration format. > > > > > > v2 of the series removes the obsolete "_t" notation in the named types. > > > > > > Wambui Karuga (5): > > > staging: octeon: remove typedef declaration for cvmx_wqe > > > staging: octeon: remove typedef declaration for cvmx_helper_link_info > > > staging: octeon: remove typedef declaration for cvmx_fau_reg_32 > > > staging: octeon: remove typedef declartion for cvmx_pko_command_word0 > > > staging: octeon: remove typedef declaration for cvmx_fau_op_size > > > > > > drivers/staging/octeon/ethernet-mdio.c | 6 +-- > > > drivers/staging/octeon/ethernet-rgmii.c | 4 +- > > > drivers/staging/octeon/ethernet-rx.c | 6 +-- > > > drivers/staging/octeon/ethernet-tx.c | 4 +- > > > drivers/staging/octeon/ethernet.c | 6 +-- > > > drivers/staging/octeon/octeon-ethernet.h | 2 +- > > > drivers/staging/octeon/octeon-stubs.h | 56 ++++++++++++------------ > > > 7 files changed, 43 insertions(+), 41 deletions(-) > > > > For the series: > > > > Acked-by: Julia Lawall > > This series breaks the build on MIPS/OCTEON (the only actual HW using this > driver): > > $ make ARCH=mips CROSS_COMPILE=mips64-linux-gnu- cavium_octeon_defconfig > $ make ARCH=mips CROSS_COMPILE=mips64-linux-gnu- > [...] > CC drivers/staging/octeon/ethernet.o > In file included from drivers/staging/octeon/ethernet.c:22: > drivers/staging/octeon/octeon-ethernet.h:94:12: warning: 'union cvmx_helper_link_info' declared inside parameter list will not be visible outside of this definition or declaration > union cvmx_helper_link_info li); > ^~~~~~~~~~~~~~~~~~~~~ > drivers/staging/octeon/ethernet.c: In function 'cvm_oct_free_work': > drivers/staging/octeon/ethernet.c:177:21: error: dereferencing pointer to incomplete type 'struct cvmx_wqe' > int segments = work->word2.s.bufs; > ^~ > drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_open': > drivers/staging/octeon/ethernet.c:463:30: error: storage size of 'link_info' isn't known > union cvmx_helper_link_info link_info; > ^~~~~~~~~ > > etc. > > Probably all these patches need to be reverted. Ick :( What is the git commit ids here that should be reverted? thanks, greg k-h