From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58886CA9EC0 for ; Mon, 28 Oct 2019 19:03:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3275F214B2 for ; Mon, 28 Oct 2019 19:03:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Ntu1jzmh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729513AbfJ1TDY (ORCPT ); Mon, 28 Oct 2019 15:03:24 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:54542 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727218AbfJ1TDX (ORCPT ); Mon, 28 Oct 2019 15:03:23 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9SIx2ic177038; Mon, 28 Oct 2019 19:03:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=6agxqUj4VUttRHvYAAr3cLu5nf2S/KDZSzHnLTVjMgs=; b=Ntu1jzmhDcHN5V6tBrLbuw7Wuvb3uKmxLygQd6DWuN5wFY1jNUw4MVhQ0FLLk32dBfEw zk1XOXQXeoLnOqdP8XDYfVZjGXuGy1vh2aNnG/I/a5c9efnYRPbXssRDKEmjezymjKoN 199v2L8JXX1UFGpxrmrOtRft4EGRBnbiOxM4qxtfztzXHXgMgDHebmfF45ureDwrS9ba jAiXHmyTi5DQUxsHdJ8ObncklYWb50xNQChr4ulxox0grzK8+jSDnpAQ7F15znRQ4iiG 98hWo3qL3gnf0AoENsYcxDPNQPC54QJb3zYsrd5oN1DHrYAq5D4vckKgJ7wIpQxjhCSJ YA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2vve3q41mp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2019 19:03:13 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9SIvqrJ191966; Mon, 28 Oct 2019 19:03:13 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2vwakyhj44-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2019 19:03:13 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9SJ394i005045; Mon, 28 Oct 2019 19:03:10 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 28 Oct 2019 12:03:09 -0700 Date: Mon, 28 Oct 2019 22:02:59 +0300 From: Dan Carpenter To: Cristiane Naves Cc: outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org, Florian Schilhabel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Julia Lawall , Larry Finger Subject: Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis Message-ID: <20191028190259.GF1944@kadam> References: <158960d90adff42169bb7ce968a4082bf3e73387.1572273794.git.cristianenavescardoso09@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158960d90adff42169bb7ce968a4082bf3e73387.1572273794.git.cristianenavescardoso09@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9424 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910280180 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9424 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910280181 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote: > Fix alignment should match open parenthesis. Issue found by checkpatch. > > Signed-off-by: Cristiane Naves > --- > drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++----------------- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c > index af12c16..304d031 100644 > --- a/drivers/staging/rtl8712/rtl8712_recv.c > +++ b/drivers/staging/rtl8712/rtl8712_recv.c > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv, > precvbuf->ref_cnt = 0; > precvbuf->adapter = padapter; > list_add_tail(&precvbuf->list, > - &(precvpriv->free_recv_buf_queue.queue)); > + (&precvpriv->free_recv_buf_queue.queue)); You did this correctly in v2. - &(precvpriv->free_recv_buf_queue.queue)); + &precvpriv->free_recv_buf_queue.queue); > precvbuf++; > } > precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF; > tasklet_init(&precvpriv->recv_tasklet, regards, dan carpenter