From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9997CA9EC4 for ; Tue, 29 Oct 2019 08:32:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76BB92067D for ; Tue, 29 Oct 2019 08:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572337947; bh=LgpjDceusfkD7Sr5vD/eZjEXHmIU2YNB4j9b5lzHmo0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qx8+irRV+hKf6Pc7ig+Ovh0ndwVGeBZ/uhe8FJARDBkTl7WnBDgORiKtGecFym7/7 piLSIgMNkhC2M/UZ5n065V+ff6FcSNsWXeUn5RfKLwZQVXyQRxSPdMdxKwm3j1Mpm6 ApG4IRoVCRI6oP8N+dMyWUxj8aRK3hLROq1ksp4M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729504AbfJ2Ic0 (ORCPT ); Tue, 29 Oct 2019 04:32:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:36016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728550AbfJ2Ic0 (ORCPT ); Tue, 29 Oct 2019 04:32:26 -0400 Received: from localhost (unknown [91.217.168.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16AFA2054F; Tue, 29 Oct 2019 08:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572337945; bh=LgpjDceusfkD7Sr5vD/eZjEXHmIU2YNB4j9b5lzHmo0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GGvnrn390c/UQVTkzapbjh2Z7Bda5iNhkVt/h2iHLdpA0sOd7PSML/eijBBozGnnZ 6LMZz6IHyFkPmVK01u7esqQTlv0Mb37A1djm8Zo5fvxtIos7lzMUoFBGVjqJiosJxn UXpKPJ8stfkM7ARLl0xpAzTAUAVWJeB1lqECc9x4= Date: Tue, 29 Oct 2019 09:32:22 +0100 From: Greg Kroah-Hartman To: Ikjoon Jang Cc: linux-pm@vger.kernel.org, "Rafael J . Wysocki" , "Pavel Machek )" , Len Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuidle: undelaying cpuidle in dpm_{suspend|resume}() Message-ID: <20191029083222.GA558937@kroah.com> References: <20191029073145.154869-1-ikjn@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029073145.154869-1-ikjn@chromium.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 03:31:45PM +0800, Ikjoon Jang wrote: > cpuidle is paused only during dpm_suspend_noirq() ~ dpm_resume_noirq(). > But some device drivers need random sized IOs in dpm_{suspend|resume}() > stage (e.g. re-downloading firmware in resume). > And with such a device, cpuidle's latencies could be critical to > response time of system suspend/resume. > > To minimize those latencies, we could apply pm_qos to such device drivers, > but simply undelaying cpuidle from dpm_suspend_noirq() to dpm suspend() > seems no harm. > --- > drivers/base/power/main.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) no signed-off-by? :(