From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08474CA9EAE for ; Tue, 29 Oct 2019 14:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC3CB2087E for ; Tue, 29 Oct 2019 14:00:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZHc3abwN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388903AbfJ2OA4 (ORCPT ); Tue, 29 Oct 2019 10:00:56 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:32844 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727255AbfJ2OA4 (ORCPT ); Tue, 29 Oct 2019 10:00:56 -0400 Received: by mail-qt1-f195.google.com with SMTP id y39so14953605qty.0; Tue, 29 Oct 2019 07:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rTascIDkhsRKyjbJRI9Qw1x1aWYBVRF+G+MqIT5POPs=; b=ZHc3abwNaK++Dko3PvPts93TVzUV3oubJdTfCEVwWK9owhBuh9xJMHmhF42CbLnl1T T536CeKakQQq4vJDI5jX0PW6Tdt+L07ZWrigvIW9xrao7PEjDwG9r5TEWIRi28RM2TrK jh8fGkKtJSNbN9nuJa+aIxxFEOLkvsL2mSAVY84Y6s8Y2kMBD2TETVQm/f4tXTwkZBQc oOmDa20AJsgnI3CbJh04OxeoBQPVodWKrbDp6XrJZ5uqj5CnBU87EEhhNAUS/396ePkd +b7rnVlzRRAvPOEfkqs7FFdS+GGiT2KHnAAh9BHbofsOOc2iq1v3OMM3TulhK0so1haB Ed/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rTascIDkhsRKyjbJRI9Qw1x1aWYBVRF+G+MqIT5POPs=; b=q+xbzr+vWUzO2vuY9n2RQfHAlwG128En4AXynd0+4V6e+L2YPF3092Xur2+Gsoruyq vrXXECcOe4q8snKVtiVq8cztT0rVq9fJjKyjr15+GlnoLDakOQDz4YOtl5QpDbpwIVjb 5T/89o7KorqcWDU14qFlBDjjS9BwKqVpsLkspNp858VF9dEowt3+1M+3Ibnrn1KPnvfC jtVQ3DVWyshnDxxHBsHKins30zVIw59gZEyRt40BZtu5o2PmkCeyI5RFLCXRtA3j2eHS Jp5NBslY4PDGfyHz8G6gifRFH158aKusD+A9rTibGL7LzE1v3Re6wuuYBdfNOofzCxYM dO7g== X-Gm-Message-State: APjAAAWmNvvzu1x65ZNFKNjvkRTXLeOUNf8FRru0LGY9AKVG2+rIWmBR qdsesnWCUCOa4SwRK0nFp1M= X-Google-Smtp-Source: APXvYqxNLUDgaMCOSR9d6bxbT2x57hmz/rT4Sg4RvgfmDv4dGLRKXZSh8tg0VzRr/zldQ1vEeNuA5Q== X-Received: by 2002:a05:6214:1812:: with SMTP id o18mr23804244qvw.33.1572357655321; Tue, 29 Oct 2019 07:00:55 -0700 (PDT) Received: from quaco.ghostprotocols.net ([179.97.35.50]) by smtp.gmail.com with ESMTPSA id j4sm7215922qkf.116.2019.10.29.07.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 07:00:54 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 9D8E340D5C; Tue, 29 Oct 2019 11:00:52 -0300 (-03) Date: Tue, 29 Oct 2019 11:00:52 -0300 To: James Clark Cc: "linux-perf-users@vger.kernel.org" , "linux-kernel@vger.kernel.org" , nd , "acme@redhat.com" , "irogers@google.com" Subject: Re: [PATCH] Fixes issue when debugging debug builds of Perf. Message-ID: <20191029140052.GB4922@kernel.org> References: <20191028113340.4282-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028113340.4282-1-james.clark@arm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Oct 28, 2019 at 11:34:01AM +0000, James Clark escreveu: > When a 'make DEBUG=1' build is done, the command parser > is still built with -O6 and is hard to step through. > > This change also moves EXTRA_WARNINGS and EXTRA_FLAGS to > the end of the compilation line, otherwise they cannot be > used to override the default values. The patch came mangled, so I'm applying by hand, and separating it into two patches, the first for the first paragraph and the other for the second, ok? - Arnaldo > Signed-off-by: James Clark > --- > tools/lib/subcmd/Makefile | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile > index 5b2cd5e58df0..1c777a72bb39 100644 > --- a/tools/lib/subcmd/Makefile > +++ b/tools/lib/subcmd/Makefile > @@ -19,8 +19,7 @@ MAKEFLAGS += --no-print-directory > > LIBFILE = $(OUTPUT)libsubcmd.a > > -CFLAGS := $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) > -CFLAGS += -ggdb3 -Wall -Wextra -std=gnu99 -fPIC > +CFLAGS := -ggdb3 -Wall -Wextra -std=gnu99 -fPIC > > ifeq ($(DEBUG),0) > ifeq ($(feature-fortify-source), 1) > @@ -28,7 +27,9 @@ ifeq ($(DEBUG),0) > endif > endif > > -ifeq ($(CC_NO_CLANG), 0) > +ifeq ($(DEBUG),1) > + CFLAGS += -O0 > +else ifeq ($(CC_NO_CLANG), 0) > CFLAGS += -O3 > else > CFLAGS += -O6 > @@ -43,6 +44,8 @@ CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE > > CFLAGS += -I$(srctree)/tools/include/ > > +CFLAGS += $(EXTRA_WARNINGS) $(EXTRA_CFLAGS) > + > SUBCMD_IN := $(OUTPUT)libsubcmd-in.o > > all: > -- > 2.23.0 -- - Arnaldo