From: Greg KH <gregkh@linuxfoundation.org>
To: zhong jiang <zhongjiang@huawei.com>
Cc: akinobu.mita@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
Date: Wed, 30 Oct 2019 10:10:51 +0100 [thread overview]
Message-ID: <20191030091051.GA634735@kroah.com> (raw)
In-Reply-To: <1572423756-59943-1-git-send-email-zhongjiang@huawei.com>
On Wed, Oct 30, 2019 at 04:22:36PM +0800, zhong jiang wrote:
> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
Why does this matter? What does this change? You are changing how some
of the file reference counting works now, are you sure this is ok?
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-30 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 8:22 [PATCH] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops zhong jiang
2019-10-30 9:10 ` Greg KH [this message]
2019-10-30 9:31 ` zhong jiang
2019-10-30 10:29 ` Akinobu Mita
2019-10-30 12:09 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030091051.GA634735@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akinobu.mita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox