From: Joerg Roedel <jroedel@suse.de>
To: YueHaibing <yuehaibing@huawei.com>
Cc: joro@8bytes.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
geert+renesas@glider.be
Subject: Re: [PATCH -next] iommu/ipmmu-vmsa: Remove dev_err() on platform_get_irq() failure
Date: Wed, 30 Oct 2019 10:17:01 +0100 [thread overview]
Message-ID: <20191030091701.GN838@suse.de> (raw)
In-Reply-To: <20191023135941.15000-1-yuehaibing@huawei.com>
On Wed, Oct 23, 2019 at 09:59:41PM +0800, YueHaibing wrote:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/iommu/ipmmu-vmsa.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied for v5.4, thanks.
prev parent reply other threads:[~2019-10-30 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:59 [PATCH -next] iommu/ipmmu-vmsa: Remove dev_err() on platform_get_irq() failure YueHaibing
2019-10-23 14:36 ` Geert Uytterhoeven
2019-10-30 9:17 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030091701.GN838@suse.de \
--to=jroedel@suse.de \
--cc=geert+renesas@glider.be \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox