[PATCH v1] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup

Saurav Girepunje
2019-10-29T17:09:03Z

Remove multiple kfree statement from phram_setup() in phram.c

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---

Change in v1:

- Add change suggested by Miquel Raynal <miquel.raynal@bootlin.com>
"The goto statement should not describe from where it is called but the
action it is supposed to take. 'goto free_nam;' would be better."

drivers/mtd/devices/phram.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index c467286ca007..38f95a1517ac 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -243,22 +243,22 @@ static int phram_setup(const char *val)

ret = parse_num64(&start, token[1]);
if (ret) {
- kfree(name);
parse_err("illegal start address\n");
+ goto free_nam;
}

ret = parse_num64(&len, token[2]);
if (ret) {
- kfree(name);
parse_err("illegal device length\n");
+ goto free_nam;
}

ret = register_device(name, start, len);
if (!ret)
pr_info("%s device: %#llx at %#llx\n", name, len, start);
- else
- kfree(name);

+free_nam:
+ kfree(name);
return ret;
}

--
2.20.1