From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B95DCA9EC7 for ; Wed, 30 Oct 2019 18:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 727602087E for ; Wed, 30 Oct 2019 18:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572458766; bh=rZB+jB/GhHIadQPBUNnMZMqEdc0Z25SHClG1fS9zNIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=poVVPyuP2c6EXMjs970MYADUi4WlYwHClQoP2jiRi3Fhk0lJBx9ujl9bFiRqnCjiw 3muyUAjJPPtSqT+eGMrpthtzRzpMDb6iPCcf/SnTwOkeIAWRYZG2GjDEc0CHWDcZQt oEPgiRMTk3ksVvXG4OMWP8wYj1FR+tEU2d0uFu20= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727785AbfJ3SGF (ORCPT ); Wed, 30 Oct 2019 14:06:05 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:44395 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727762AbfJ3SGE (ORCPT ); Wed, 30 Oct 2019 14:06:04 -0400 Received: by mail-ed1-f68.google.com with SMTP id b18so2505459edr.11; Wed, 30 Oct 2019 11:06:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FrSVqR4rubXbOdoO4xIlrJ/g2AylU6DO+rRGS6ug+TM=; b=uVssUMm6cjQdfCDkO8kwHYzIulhlCr5/nE+SqtXo0+491WDXG7QWahSPeru0ZFYibn leaeEqPllET5IXOrX4qF6Skb+8y1383gTzhgM5hVDvNNiuS9QUNPygPkJ9O9n9XFosCB t+064iV3AKOecHEQxo0lCsGy+Q/rX4oq83ZEMGu7xVqJWX/56DH16NdLtW6QMgP7NhaG 74a5oG4XF2fx3XwBYWxnejHJ5mfEeI2USU+utgsQq/fiZfpH2LEY0Gqttw508k1Kft6U uwYojeyMFqv+WxjK6+JSCSapwJUwX88ydsGPBd5F9aXWBefdXvvbR8KZEid32+reyFKn gbCg== X-Gm-Message-State: APjAAAU7NLQ/9XMwvQlISZmY5zwAlw6oVhpL/Cv1wY0Xn1hpMpSSC8ki VurfnIUFAYuWU6jXm+qZH6s= X-Google-Smtp-Source: APXvYqzu4HoYoArCMfuZiHHYx5XLueApspB4kJAI+3/Kg9OneW/pR4iKPXYNA//dTC9X/UDqISTrsw== X-Received: by 2002:a17:906:c793:: with SMTP id cw19mr886699ejb.25.1572458762736; Wed, 30 Oct 2019 11:06:02 -0700 (PDT) Received: from kozik-lap ([194.230.155.180]) by smtp.googlemail.com with ESMTPSA id d26sm17952edu.37.2019.10.30.11.06.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Oct 2019 11:06:01 -0700 (PDT) Date: Wed, 30 Oct 2019 19:05:59 +0100 From: Krzysztof Kozlowski To: Dan Carpenter Cc: Kukjin Kim , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] soc: samsung: exynos-asv: Potential NULL dereference in exynos_asv_update_opps() Message-ID: <20191030180559.GA8016@kozik-lap> References: <20191029182742.GC17569@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191029182742.GC17569@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 29, 2019 at 09:27:42PM +0300, Dan Carpenter wrote: > The dev_pm_opp_get_opp_table() returns error pointers if it's disabled > in the config and it returns NULL if there is an error. This code only > checks for error pointers so it could lead to an Oops inside the > dev_pm_opp_put_opp_table() function. > > Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver") > Signed-off-by: Dan Carpenter > --- > When we add a new driver, could we specify the which prefix will be used > going forward? In other words commit 5ea428595cc5 could have the > prefix "soc: samsung: exynos-asv: Add Exynos Adaptive Supply Voltage > driver". The "exynos-asv" bit was missing so the first person to send a > fix has to guess what is desired. Indeed, I usually do not add it on first commit to avoid duplication (prefix and later explanation) but I see that it would be helpful. Thanks, applied. Best regards, Krzysztof