Re: [PATCH v3 08/32] mtd: spi-nor: Pointer parameter for SR in spi_nor_read_sr()

Tudor.Ambarus
2019-11-02T10:42:40Z

On 10/29/2019 01:17 PM, Tudor Ambarus - M18064 wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Let the callers pass the pointer to the DMA-able buffer where
> the value of the Status Register will be written. This way we
> avoid the casts between int and u8, which can be confusing.
>
> Callers stop compare the return value of spi_nor_read_sr() with negative,
> spi_nor_read_sr() returns 0 on success and -errno otherwise.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 117 +++++++++++++++++++++++-------------------
> 1 file changed, 64 insertions(+), 53 deletions(-)

Replaced &nor->bouncebuf[0] with nor->bouncebuf and &sr_cr[0] with sr_cr and
applied to spi-nor/next. Thanks.