Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding

Sakari Ailus
2019-10-30T11:54:19Z

Hi Nabuvannan,

On Wed, Oct 30, 2019 at 03:19:01PM +0530, Manivannan Sadhasivam wrote:
> Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also
> add MAINTAINERS entry for the binding and driver.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 102 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
> new file mode 100644
> index 000000000000..c04ec2203268
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
> @@ -0,0 +1,94 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/imx296.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor
> +
> +maintainers:
> + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> +
> +description: |-
> + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image
> + sensor with square pixel array and 1.58 M effective pixels. This chip
> + features a global shutter with variable charge-integration time. It is
> + programmable through I2C and 4-wire interfaces. The sensor output is
> + available via CSI-2 serial data output (1 Lane).
> +
> +properties:
> + compatible:
> + const: sony,imx296
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + description:
> + Input clock for the sensor.
> + items:
> + - const: mclk
> +
> + clock-frequency:
> + description:
> + Frequency of the mclk clock in Hertz.
> +
> + vddo-supply:
> + description:
> + Definition of the regulator used as interface power supply.
> +
> + vdda-supply:
> + description:
> + Definition of the regulator used as analog power supply.
> +
> + vddd-supply:
> + description:
> + Definition of the regulator used as digital power supply.
> +
> + reset-gpios:
> + description:
> + The phandle and specifier for the GPIO that controls sensor reset.
> + maxItems: 1
> +
> + port: true

You're missing "type: object" under port.

--
Regards,

Sakari Ailus