Re: [PATCH v1 01/12] powerpc/pseries: CMM: Implement release() function for sysfs device

David Hildenbrand
2019-11-14T12:21:35Z

On 14.11.19 10:08, Michael Ellerman wrote:
> On Thu, 2019-10-31 at 14:29:22 UTC, David Hildenbrand wrote:
>> When unloading the module, one gets
>> [ 548.188594] ------------[ cut here ]------------
>> [ 548.188596] Device 'cmm0' does not have a release() function, it is brok=
>> en and must be fixed. See Documentation/kobject.txt.
>> [ 548.188622] WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .devi=
>> ce_release+0xcc/0xf0
>> ...
>>
>> We only have on static fake device. There is nothing to do when
>> releasing the device (via cmm_exit).
>>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Vlastimil Babka <vbabka@suse.cz>
>> Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
>> Cc: Allison Randal <allison@lohutok.net>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Arun KS <arunks@codeaurora.org>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Patches 1-10 applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/7d8212747435c534c8d564fbef4541a463c976ff
>
> cheers
>

Thanks! I'll probably resend patch 11/12 to give it more attention and
to fixup one comment leftover in patch 11. I guess if we get ACKs these
two patch should also go via your tree to avoid collisions.

--

Thanks,

David / dhildenb