* [PATCH] scsi: ibmvscsi_tgt: Remove unneeded variable rc
@ 2019-11-01 12:35 Saurav Girepunje
2019-11-21 1:11 ` Tyrel Datwyler
0 siblings, 1 reply; 3+ messages in thread
From: Saurav Girepunje @ 2019-11-01 12:35 UTC (permalink / raw)
To: mikecyr, jejb, martin.petersen, linux-scsi, target-devel,
linux-kernel
Cc: saurav.girepunje
Variable rc is not modified in ibmvscsis_srp_i_logout function.
So remove unneeded variable rc.
Issue found using coccicheck tool.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index 7f9535392a93..09a4dbd0a9e5 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -2353,7 +2353,6 @@ static long ibmvscsis_srp_i_logout(struct scsi_info *vscsi,
{
struct iu_entry *iue = cmd->iue;
struct srp_i_logout *log_out = &vio_iu(iue)->srp.i_logout;
- long rc = ADAPT_SUCCESS;
if ((vscsi->debit > 0) || !list_empty(&vscsi->schedule_q) ||
!list_empty(&vscsi->waiting_rsp)) {
@@ -2369,7 +2368,7 @@ static long ibmvscsis_srp_i_logout(struct scsi_info *vscsi,
ibmvscsis_post_disconnect(vscsi, WAIT_IDLE, 0);
}
- return rc;
+ return ADAPT_SUCCESS;
}
/* Called with intr lock held */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: ibmvscsi_tgt: Remove unneeded variable rc
2019-11-01 12:35 [PATCH] scsi: ibmvscsi_tgt: Remove unneeded variable rc Saurav Girepunje
@ 2019-11-21 1:11 ` Tyrel Datwyler
2019-11-22 1:48 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Tyrel Datwyler @ 2019-11-21 1:11 UTC (permalink / raw)
To: Saurav Girepunje, mikecyr, jejb, martin.petersen, linux-scsi,
target-devel, linux-kernel
Cc: saurav.girepunje
On 11/1/19 5:35 AM, Saurav Girepunje wrote:
> Variable rc is not modified in ibmvscsis_srp_i_logout function.
> So remove unneeded variable rc.
>
> Issue found using coccicheck tool.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ibmvscsi_tgt: Remove unneeded variable rc
2019-11-21 1:11 ` Tyrel Datwyler
@ 2019-11-22 1:48 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-11-22 1:48 UTC (permalink / raw)
To: Saurav Girepunje
Cc: Tyrel Datwyler, mikecyr, jejb, martin.petersen, linux-scsi,
target-devel, linux-kernel, saurav.girepunje
>> Variable rc is not modified in ibmvscsis_srp_i_logout function. So
>> remove unneeded variable rc.
>>
>> Issue found using coccicheck tool.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>
> Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Applied to 5.5/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-22 1:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-01 12:35 [PATCH] scsi: ibmvscsi_tgt: Remove unneeded variable rc Saurav Girepunje
2019-11-21 1:11 ` Tyrel Datwyler
2019-11-22 1:48 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).