From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1892CCA9EC7 for ; Sat, 2 Nov 2019 17:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9E3221855 for ; Sat, 2 Nov 2019 17:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572714863; bh=vXa/QkOcySgkQ/5on8HqE0PLqKV33p9ytcqF+FfU5nU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=04D8U8+r2QzfkD+tUHM7tQpW4FYrrYN9Mu2xD4Mmo340gF4Zh5/nMNh3YDp8lkUaI R7fikZLwKwJvlBD03s1WC24HyL/ylkT/5Cpj+A7oAhgLZPN9f1BqZFgWIuIRe1Ms4x hqyAdjfCs9lJNpGBonboyw6763sWI1/75fpAYIUw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbfKBROW (ORCPT ); Sat, 2 Nov 2019 13:14:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:59422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbfKBROW (ORCPT ); Sat, 2 Nov 2019 13:14:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7848021855; Sat, 2 Nov 2019 17:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572714862; bh=vXa/QkOcySgkQ/5on8HqE0PLqKV33p9ytcqF+FfU5nU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hXBWS7duijEfYwtFet1jD6NAD47LDPQHmxGlkV1oPIB7asl1Did/JNgSQycI5PlLV i19vNPoYt9c2no46JN5KUKHraNhdtmIMkZf5XusTJ3N1pEeoho7FmP1h9U/uOsoGff YLNAdeLXD9px3DUxHGLyXgh6tnXwoueUHMOfg3hA= Date: Sat, 2 Nov 2019 18:14:19 +0100 From: Greg Kroah-Hartman To: Alexander Shishkin Cc: linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [GIT PULL 1/7] intel_th: gth: Fix the window switching sequence Message-ID: <20191102171419.GA484428@kroah.com> References: <20191028070651.9770-1-alexander.shishkin@linux.intel.com> <20191028070651.9770-2-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028070651.9770-2-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 09:06:45AM +0200, Alexander Shishkin wrote: > Commit 8116db57cf16 ("intel_th: Add switch triggering support") added > a trigger assertion of the CTS, but forgot to de-assert it at the end > of the sequence. This results in window switches randomly not happening. > > Fix that by de-asserting the trigger at the end of the window switch > sequence. > > Signed-off-by: Alexander Shishkin > Reviewed-by: Andy Shevchenko > --- > drivers/hwtracing/intel_th/gth.c | 3 +++ > 1 file changed, 3 insertions(+) Shouldn't this have a Fixes: tag and a cc: stable@ in it? I can add it if you say it's ok to. thanks, greg k-h