Re: [PATCH 12/12] cpu: Hide cpu_up/down

Thomas Gleixner
2019-11-19T22:25:18Z

On Wed, 30 Oct 2019, Qais Yousef wrote:
> -int cpu_down(unsigned int cpu)
> +static int cpu_down(unsigned int cpu)
> {
> return do_cpu_down(cpu, CPUHP_OFFLINE);
> }
> -EXPORT_SYMBOL(cpu_down);

The exports should be gone already at this point, right?

> +/*
> + * This function is meant to be used by device core cpu subsystem.
> + *
> + * Other subsystems should use device_offline(get_cpu_device(cpu)) instead.
> + */

Can you please use proper kernel-doc function documentation?

Thanks,

tglx