* [PATCH] FBTFT: Changed delay function.
@ 2019-11-03 15:40 Rama Kumar
2019-11-03 15:59 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Rama Kumar @ 2019-11-03 15:40 UTC (permalink / raw)
To: gregkh; +Cc: jeremy, nishadkamdar, linux-kernel, devel, Rama Kumar
Hi,
Changed udelay() to usleep_range() based on the document in the path, "Documentation/timers/timers-howto.rst". It was suggested to use usleep_range() function for sleeping duration between 10us - 20 ms. original code used udelay() for sleeping 20 us.
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
index eeeeec97ad27..471a145e3c00 100644
--- a/drivers/staging/fbtft/fb_agm1264k-fl.c
+++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
@@ -85,7 +85,7 @@ static void reset(struct fbtft_par *par)
dev_dbg(par->info->device, "%s()\n", __func__);
gpiod_set_value(par->gpio.reset, 0);
- udelay(20);
+ usleep_range(20,20);
gpiod_set_value(par->gpio.reset, 1);
mdelay(120);
}
--
Signed-off-by: Rama Kumar <ramakumar.kanasundara@gmail.com>
Thanks,
Rama Kumar
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] FBTFT: Changed delay function.
2019-11-03 15:40 [PATCH] FBTFT: Changed delay function Rama Kumar
@ 2019-11-03 15:59 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-11-03 15:59 UTC (permalink / raw)
To: Rama Kumar; +Cc: devel, linux-kernel, nishadkamdar
On Sun, Nov 03, 2019 at 09:40:03AM -0600, Rama Kumar wrote:
>
> Hi,
>
> Changed udelay() to usleep_range() based on the document in the path, "Documentation/timers/timers-howto.rst". It was suggested to use usleep_range() function for sleeping duration between 10us - 20 ms. original code used udelay() for sleeping 20 us.
>
> ---
> drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index eeeeec97ad27..471a145e3c00 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -85,7 +85,7 @@ static void reset(struct fbtft_par *par)
> dev_dbg(par->info->device, "%s()\n", __func__);
>
> gpiod_set_value(par->gpio.reset, 0);
> - udelay(20);
> + usleep_range(20,20);
> gpiod_set_value(par->gpio.reset, 1);
> mdelay(120);
> }
> --
> Signed-off-by: Rama Kumar <ramakumar.kanasundara@gmail.com>
Always run checkptch.pl on patches you send out so you don't get grumpy
maintainers telling you to run checkpatch.pl on your patch :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-03 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-03 15:40 [PATCH] FBTFT: Changed delay function Rama Kumar
2019-11-03 15:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox