From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBEACA9EB0 for ; Sun, 3 Nov 2019 17:50:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C13C20848 for ; Sun, 3 Nov 2019 17:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572803416; bh=PlOin1l6slPT5/U5vXvLzfTrvHg0QrB1rLhKWDlIkWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YuBH9PYE6lZRVnnUgkbPMlaAgsMjeF/dtPcwQA7J2UaL8fm/bQQ9TJuUC+DqTNnOq 68TzTTR9ZFja2FYPQC6dbNDvox0n3RYR05epDF6QetZX6ynIdV+lp6uJqPKQrCpPe0 tkJwtIMTjO8CbTI5T8A2Y8lnlEjK+bGi82oI0Kb0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727915AbfKCRuP (ORCPT ); Sun, 3 Nov 2019 12:50:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:60864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727758AbfKCRuO (ORCPT ); Sun, 3 Nov 2019 12:50:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B643F2084D; Sun, 3 Nov 2019 17:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572803414; bh=PlOin1l6slPT5/U5vXvLzfTrvHg0QrB1rLhKWDlIkWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Aq8wmak45kO3jB3Frea8gx6xhrITGJ1OwasEFIYEoRmkjy+c/TEApVPZ3VSPxiOKu Dk4vZMh3aVmIbzn/AikMxU0KZgg1p1BG/iJdGU9rbLGmZLK1R2WEte69miitRFPf1A HLLvO3ZZiahEl89uP1Z4XGv48j2PMFH/O68i7X1o= Date: Sun, 3 Nov 2019 18:50:11 +0100 From: Greg Kroah-Hartman To: Drew DeVault Cc: Luis Chamberlain , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , ~sircmpwn/public-inbox@lists.sr.ht Subject: Re: [PATCH] firmware loader: log path to loaded firmwares Message-ID: <20191103175011.GA751209@kroah.com> References: <20191103173837.1861-1-sir@cmpwn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191103173837.1861-1-sir@cmpwn.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 03, 2019 at 12:38:38PM -0500, Drew DeVault wrote: > This is useful for users who are trying to identify the firmwares in use > on their system. > > Signed-off-by: Drew DeVault > --- > drivers/base/firmware_loader/main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c > index bf44c79beae9..139d40a2f423 100644 > --- a/drivers/base/firmware_loader/main.c > +++ b/drivers/base/firmware_loader/main.c > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include > > #include > > @@ -504,6 +505,7 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv, > path); > continue; > } > + printk(KERN_INFO "Loading firmware from %s\n", path); And it's totally noisy :( Also, if you have a 'struct device' you should always use the dev_*() calls instead, which will show you exactly what device is asking for what. Please just make this a debug call, that way you can turn it on dynamically if you really want to see what firmware is attempting to be loaded. thanks, greg k-h