[PATCH V5 13/14] perf, tools, stat: Check Topdown Metric group

kan.liang
2019-11-03T23:30:47Z

The slots event is required in a Topdown Metric group.

Add a check to examine the Topdown Metric group. Error out if there is
no slots event detected.

Only check the group on the platform which using topdown_metric_attrs,
e.g. Ice Lake.

Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---

New for V5

tools/perf/builtin-stat.c | 72 +++++++++++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 0ed191bf8b5e..948a0300410c 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1134,6 +1134,72 @@ static int topdown_filter_events(const char **attr, char **str, bool use_group)
return 0;
}

+/* Event encoding for Topdown Metric events */
+#define TOPDOWN_SLOTS 0x0400
+#define TOPDOWN_RETIRE 0x1000
+#define TOPDOWN_BAD_SPEC 0x1100
+#define TOPDOWN_FE_BOUND 0x1200
+#define TOPDOWN_BE_BOUND 0x1300
+
+static bool is_topdown_metric_event(struct evsel *counter)
+{
+ if (!counter->pmu_name)
+ return false;
+
+ if (strcmp(counter->pmu_name, "cpu"))
+ return false;
+
+ if ((counter->core.attr.config == TOPDOWN_RETIRE) ||
+ (counter->core.attr.config == TOPDOWN_BAD_SPEC) ||
+ (counter->core.attr.config == TOPDOWN_FE_BOUND) ||
+ (counter->core.attr.config == TOPDOWN_BE_BOUND))
+ return true;
+
+ return false;
+}
+
+static bool is_topdown_slots_event(struct evsel *counter)
+{
+ if (!counter->pmu_name)
+ return false;
+
+ if (strcmp(counter->pmu_name, "cpu"))
+ return false;
+
+ if (counter->core.attr.config == TOPDOWN_SLOTS)
+ return true;
+
+ return false;
+}
+
+static bool topdown_check_group_member(void)
+{
+ struct evsel *counter, *leader, *member;
+ bool has_slots;
+
+ if (!pmu_have_event("cpu", topdown_metric_attrs[0]))
+ return true;
+
+ evlist__for_each_entry(evsel_list, counter) {
+ if (!is_topdown_metric_event(counter))
+ continue;
+
+ leader = counter->leader;
+ has_slots = false;
+
+ for_each_group_evsel(member, leader) {
+ if (is_topdown_slots_event(member))
+ has_slots = true;
+ counter = member;
+ }
+
+ if (!has_slots)
+ return false;
+ }
+
+ return true;
+}
+
__weak bool arch_topdown_check_group(bool *warn)
{
*warn = false;
@@ -1740,6 +1806,12 @@ int cmd_stat(int argc, const char **argv)
(const char **) stat_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
perf_stat__collect_metric_expr(evsel_list);
+
+ if (!topdown_check_group_member()) {
+ fprintf(stderr, "Topdown group must include slots event\n");
+ goto out;
+ }
+
perf_stat__init_shadow_stats();

if (stat_config.csv_sep) {
--
2.17.1