Re: [PATCH 3/3] media: cedrus: Increase maximum supported size

Paul Kocialkowski
2019-11-04T10:14:53Z

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

Hi,

On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote:
> There are few variations of 4k resolutions. The biggest one is
> 4096x2304 which is also supported by HW. It has also nice property that
> both width and size are divisible by maximum HEVC CTB size, which is 64.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

As I said on the other email, it would be nice to eventually reflect the actual
per-platform maximum dimensions instead of hardcoding the maximum for all
platforms confounded.

Cheers,

Paul

> ---
> drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> index cc15a5cf107d..15cf1f10221b 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> @@ -29,8 +29,8 @@
>
> #define CEDRUS_MIN_WIDTH 16U
> #define CEDRUS_MIN_HEIGHT 16U
> -#define CEDRUS_MAX_WIDTH 3840U
> -#define CEDRUS_MAX_HEIGHT 2160U
> +#define CEDRUS_MAX_WIDTH 4096U
> +#define CEDRUS_MAX_HEIGHT 2304U
>
> static struct cedrus_format cedrus_formats[] = {
> {
> --
> 2.23.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]