From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: samsung: rename to fix build warning
Date: Mon, 4 Nov 2019 17:43:51 +0100 [thread overview]
Message-ID: <20191104164351.GA2269025@kroah.com> (raw)
In-Reply-To: <20191018194707.27188-1-sudipm.mukherjee@gmail.com>
On Fri, Oct 18, 2019 at 08:47:07PM +0100, Sudip Mukherjee wrote:
> The build of arm allmodconfig gives a warning:
>
> warning: same module names found:
> drivers/tty/serial/samsung.ko
> drivers/mtd/nand/onenand/samsung.ko
>
> Rename drivers/tty/serial/samsung.c to drivers/tty/serial/samsung_tty.c
> to fix the warning.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> drivers/tty/serial/Makefile | 2 +-
> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)
>
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index 863f47056539..d056ee6cca33 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -30,7 +30,7 @@ obj-$(CONFIG_SERIAL_PXA_NON8250) += pxa.o
> obj-$(CONFIG_SERIAL_PNX8XXX) += pnx8xxx_uart.o
> obj-$(CONFIG_SERIAL_SA1100) += sa1100.o
> obj-$(CONFIG_SERIAL_BCM63XX) += bcm63xx_uart.o
> -obj-$(CONFIG_SERIAL_SAMSUNG) += samsung.o
> +obj-$(CONFIG_SERIAL_SAMSUNG) += samsung_tty.o
> obj-$(CONFIG_SERIAL_MAX3100) += max3100.o
> obj-$(CONFIG_SERIAL_MAX310X) += max310x.o
> obj-$(CONFIG_SERIAL_IP22_ZILOG) += ip22zilog.o
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung_tty.c
> similarity index 100%
> rename from drivers/tty/serial/samsung.c
> rename to drivers/tty/serial/samsung_tty.c
> --
> 2.11.0
>
What are you going to break if you rename this module?
What configs enable both of these other than allmodconfig? Why rename
the tty driver and not the mtd driver? Why not both?
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-04 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 19:47 [PATCH] tty: serial: samsung: rename to fix build warning Sudip Mukherjee
2019-11-04 16:43 ` Greg Kroah-Hartman [this message]
2019-11-11 15:18 ` Sudip Mukherjee
2019-11-14 3:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104164351.GA2269025@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox