From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF59CA9EC9 for ; Mon, 4 Nov 2019 22:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 429CF204FD for ; Mon, 4 Nov 2019 22:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905884; bh=iOwJt4PH0vF7tQobDg6MlteMOkoS0OlM2wN4cLQY6wE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KRavGxl6gXg7wfDm0c1SUJmUD1JPenDpVVC9cXECBcedb33jrNaH6uczVKX/qlnO5 YeNmLvpUu2Xr50WrxWuAcXhjNJb+AHz51jBhA2xz9wc2s47bwwgpVvE7wOX+3yNyyW m/j3t1Hm1QX00FUyZhfw4a8jNhNhYei/MnyWza4M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389844AbfKDWSD (ORCPT ); Mon, 4 Nov 2019 17:18:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:60566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389224AbfKDWCO (ORCPT ); Mon, 4 Nov 2019 17:02:14 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 391092089C; Mon, 4 Nov 2019 22:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572904933; bh=iOwJt4PH0vF7tQobDg6MlteMOkoS0OlM2wN4cLQY6wE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mzofvc2Tw965kMI4iB12AHdReN3n0VsvsV8Mwy63fpcZjl83sjzpd+J11fGZR2fgh +D7nvPeQ2wZiCELktB4dbivKQQDppw9F4ALvsqwlQUQ1NOj2OO/ik+QQwXjSl11PE7 qczvTeP7+bT/dZ4wam7jS1aE6Na3pWYT7vS7GllA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.19 120/149] USB: serial: whiteheat: fix potential slab corruption Date: Mon, 4 Nov 2019 22:45:13 +0100 Message-Id: <20191104212144.726422498@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212126.090054740@linuxfoundation.org> References: <20191104212126.090054740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 1251dab9e0a2c4d0d2d48370ba5baa095a5e8774 upstream. Fix a user-controlled slab buffer overflow due to a missing sanity check on the bulk-out transfer buffer used for control requests. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191029102354.2733-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/whiteheat.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/serial/whiteheat.c +++ b/drivers/usb/serial/whiteheat.c @@ -571,6 +571,10 @@ static int firm_send_command(struct usb_ command_port = port->serial->port[COMMAND_PORT]; command_info = usb_get_serial_port_data(command_port); + + if (command_port->bulk_out_size < datasize + 1) + return -EIO; + mutex_lock(&command_info->mutex); command_info->command_finished = false;